Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v3

2018-11-16 Thread Kuehling, Felix
On 2018-11-16 4:35 p.m., Alex Deucher wrote: >> + ring->doorbell_index += 0x400; > I don't quite understand how this works. Why don't we have to adjust > the doorbell range registers in the nbio code? NBIO only looks at the lower 12 bits of the doorbell address. So adding 0

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v3

2018-11-16 Thread Yang, Philip
On 2018-11-16 4:35 p.m., Alex Deucher wrote: > On Fri, Nov 16, 2018 at 2:08 PM Yang, Philip wrote: >> Because increase SDMA_DOORBELL_RANGE to add new SDMA doorbell for paging >> queue will >> break SRIOV, instead we can reserve and map two doorbell pages for amdgpu, >> paging >> queues doorbell

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v3

2018-11-16 Thread Alex Deucher
On Fri, Nov 16, 2018 at 2:08 PM Yang, Philip wrote: > > Because increase SDMA_DOORBELL_RANGE to add new SDMA doorbell for paging > queue will > break SRIOV, instead we can reserve and map two doorbell pages for amdgpu, > paging > queues doorbell index use same index as SDMA gfx queues index but

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v3

2018-11-16 Thread Kuehling, Felix
Looks good to me. Reviewed-by: Felix Kuehling I hope Alex or Christian can also review this in case I'm missing something about how doorbells are used in amdgpu. Regards,   Felix On 2018-11-16 2:08 p.m., Yang, Philip wrote: > Because increase SDMA_DOORBELL_RANGE to add new SDMA doorbell for pag

[PATCH] drm/amdgpu: enable paging queue doorbell support v3

2018-11-16 Thread Yang, Philip
Because increase SDMA_DOORBELL_RANGE to add new SDMA doorbell for paging queue will break SRIOV, instead we can reserve and map two doorbell pages for amdgpu, paging queues doorbell index use same index as SDMA gfx queues index but on second page. For Vega20, after we change doorbell layout to