Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-04 Thread Yin, Tianci (Rico)
Cc: Zhang, Hawking ; amd-gfx@lists.freedesktop.org ; Cui, Flora ; Xu, Feifei ; Tuikov, Luben ; Chen, Guchun ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU [AMD Official Use Only - Internal Distribution Only] Hi Alex, If we don't skip DCN in nv_

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-03 Thread Deucher, Alexander
@lists.freedesktop.org ; Cui, Flora ; Xu, Feifei ; Tuikov, Luben ; Chen, Guchun ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU [AMD Official Use Only - Internal Distribution Only] Hi Alex, If we don't skip DCN in nv_set_ip_blocks, I find below

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-02 Thread Yin, Tianci (Rico)
ucher Sent: Tuesday, November 3, 2020 1:49 To: Deucher, Alexander Cc: Yin, Tianci (Rico) ; Zhang, Hawking ; amd-gfx@lists.freedesktop.org ; Cui, Flora ; Xu, Feifei ; Tuikov, Luben ; Chen, Guchun ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-02 Thread Alex Deucher
he display > code handle it automatically since there will be no displays in the atombios > object table. We didn't do anything special for display with the polaris > blockchain cards. > > Alex > > ________________ > From: Zhang, Hawking > Sent:

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-02 Thread Deucher, Alexander
d-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Chen, Guchun ; Cui, Flora ; Xu, Feifei ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU [AMD Public Use] Thanks very much Hawking! Hi Alex, The amdgpu_device_ip_get_ip_block() depends on the adev->i

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-11-01 Thread Yin, Tianci (Rico)
20 22:18 To: Zhang, Hawking ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Chen, Guchun ; Cui, Flora ; Xu, Feifei ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU [AMD Public Use] Maybe it would be easier to check if the

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-10-30 Thread Deucher, Alexander
Cc: Tuikov, Luben ; Deucher, Alexander ; Chen, Guchun ; Cui, Flora ; Xu, Feifei ; Long, Gang Subject: RE: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU [AMD Public Use] [AMD Public Use] I see, thanks for the clarifying. The patch is Reviewed-by: Hawking Zhang

RE: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-10-30 Thread Zhang, Hawking
gards, Hawking From: Yin, Tianci (Rico) Sent: Friday, October 30, 2020 20:05 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Chen, Guchun ; Cui, Flora ; Xu, Feifei ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headles

Recall: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-10-30 Thread Zhang, Hawking
Zhang, Hawking would like to recall the message, "[PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-10-30 Thread Zhang, Hawking
: Friday, October 30, 2020 20:05 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Chen, Guchun ; Cui, Flora ; Xu, Feifei ; Long, Gang Subject: Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU [AMD Public Use] Hi Hawking

Re: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-10-30 Thread Yin, Tianci (Rico)
-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Chen, Guchun ; Cui, Flora ; Xu, Feifei ; Long, Gang ; Yin, Tianci (Rico) Subject: RE: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU [AMD Public Use] I'm not sure I get your point on cha

RE: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-10-30 Thread Zhang, Hawking
i Yin Sent: Friday, October 30, 2020 19:32 To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Zhang, Hawking ; Chen, Guchun ; Cui, Flora ; Xu, Feifei ; Long, Gang ; Yin, Tianci (Rico) Subject: [PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

[PATCH] drm/amdgpu: fix NULL pointer crash on navi10 headless SKU

2020-10-30 Thread Tianci Yin
From: "Tianci.Yin" The crash caused by the NULL pointer of adev->ddev.mode_config.funcs in drm_kms_helper_hotplug_event(), but this function should not be called on headless SKU. Fix the mismatch between the return value of amdgpu_device_has_dc_support() and the real DCN supporting state to avoi