Re: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM

2023-05-17 Thread Alex Deucher
Thanks for fixing this up. Reviewed-by: Alex Deucher On Wed, May 17, 2023 at 5:45 AM Jack Xiao wrote: > > 1. Need flush HDP for MQD putting in vram > 2. Zero out mes MQD > > Signed-off-by: Jack Xiao > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 > drivers/gpu/drm/amd/amdgpu/mes_v10

[PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM

2023-05-17 Thread Jack Xiao
1. Need flush HDP for MQD putting in vram 2. Zero out mes MQD Signed-off-by: Jack Xiao --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 3 +++ drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 3 +++ 3 files changed, 10 insertions(+) diff --git a/drivers/g

Re: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM

2023-05-15 Thread Alex Deucher
; Sent: Monday, 15 May 2023 21:08 > To: Xiao, Jack > Cc: amd-gfx@lists.freedesktop.org ; Deucher, > Alexander > Subject: Re: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM > > On Mon, May 15, 2023 at 6:40 AM Xiao, Jack wrote: > > > > [AMD Official Use Only - Genera

Re: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM

2023-05-15 Thread Xiao, Jack
Deucher Sent: Monday, 15 May 2023 21:08 To: Xiao, Jack Cc: amd-gfx@lists.freedesktop.org ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM On Mon, May 15, 2023 at 6:40 AM Xiao, Jack wrote: > > [AMD Official Use Only - General] > > The MQD data in V

Re: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM

2023-05-15 Thread Alex Deucher
ay 12, 2023 9:13 PM > To: Xiao, Jack > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > > Subject: Re: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM > > On Fri, May 12, 2023 at 4:16 AM Jack Xiao wrote: > > > > Make the preemption optimization effect only

RE: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM

2023-05-15 Thread Xiao, Jack
ng S3. Regards, Jack -Original Message- From: Alex Deucher Sent: Friday, May 12, 2023 9:13 PM To: Xiao, Jack Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM On Fri, May 12, 2023 at 4:16 AM Jack Xiao wrote: > &g

Re: [PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM

2023-05-12 Thread Alex Deucher
On Fri, May 12, 2023 at 4:16 AM Jack Xiao wrote: > > Make the preemption optimization effect only for SRIOV, > for it caused failure to resume from S3. Can you elaborate? We ultimately want MQDs in VRAM for performance reasons even for bare metal. Alex > > Signed-off-by: Jack Xiao > --- > dr

[PATCH] drm/amdgpu: fix S3 issue if MQD in VRAM

2023-05-12 Thread Jack Xiao
Make the preemption optimization effect only for SRIOV, for it caused failure to resume from S3. Signed-off-by: Jack Xiao --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 ++- drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 7 +-- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 7 +-- 3 files changed