Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

desktop.org Subject: Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2 Am 11.09.2017 um 11:10 schrieb zhoucm1: > > > On 2017年09月11日 17:04, Christian König wrote: >>> NAK, as Roger pointed, the performance of Vulkan Dota2 drops from >>> 72fps to 24fps. >&g

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

fx@lists.freedesktop.org> Subject: Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2 Am 11.09.2017 um 11:10 schrieb zhoucm1: > > > On 2017年09月11日 17:04, Christian König wrote: >>> NAK, as Roger pointed, the performance of Vulkan Dota2 drops from >>> 72fps to

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

g) <david1.z...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2 Am 11.09.2017 um 11:10 schrieb zhoucm1: > > > On 2017年09月11日 17:04, Christian König wrote: >>> NAK, as Roger pointed, the performance of Vulkan

RE: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

[mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Monday, September 11, 2017 6:53 PM To: Zhou, David(ChunMing) <david1.z...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2 Am 11.09.2017 um 11:

RE: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

gt;; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2 Am 11.09.2017 um 11:10 schrieb zhoucm1: > > > On 2017年09月11日 17:04, Christian König wrote: >>> NAK, as Roger pointed, the performance of Vulkan Dota2 drops from >>> 72fps to 24fps. &

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

Am 11.09.2017 um 11:10 schrieb zhoucm1: On 2017年09月11日 17:04, Christian König wrote: NAK, as Roger pointed, the performance of Vulkan Dota2 drops from 72fps to 24fps. This patches will kill Per-vm-BO advantages, even drop to 1/3 of previous non-per-vm-bo. This is irrelevant and actually

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

On 2017年09月11日 17:04, Christian König wrote: NAK, as Roger pointed, the performance of Vulkan Dota2 drops from 72fps to 24fps. This patches will kill Per-vm-BO advantages, even drop to 1/3 of previous non-per-vm-bo. This is irrelevant and actually a foreseen consequence of per VM BOs. If

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

NAK, as Roger pointed, the performance of Vulkan Dota2 drops from 72fps to 24fps. This patches will kill Per-vm-BO advantages, even drop to 1/3 of previous non-per-vm-bo. This is irrelevant and actually a foreseen consequence of per VM BOs. If the performance drops is in-acceptable then the

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

NAK, as Roger pointed, the performance of Vulkan Dota2 drops from 72fps to 24fps. This patches will kill Per-vm-BO advantages, even drop to 1/3 of previous non-per-vm-bo. all moved and relocated fence have already synced, we just need to catch the va mapping but which is CS itself required,

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs

Thanks for the review, please see some comments inline. Am 08.09.2017 um 23:12 schrieb Felix Kuehling: I think this change could use a little more explanation. I also have some ideas for simplifying the code and making it easier to understand. See comments inline. But it looks good to me

[PATCH] drm/amdgpu: fix VM sync with always valid BOs v2

From: Christian König All users of a VM must always wait for updates with always valid BOs to be completed. v2: remove debugging leftovers, rename struct member Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 10

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs

+Roger, Roger, this change could also help GuoKai's issue(he needs to pass bo in first CS when enabling Per-VM-BOs). Regards, David Zhou On 2017年09月08日 20:26, Christian König wrote: Marek this one will most likely fix your issues with always valid BOs on Raven. Please give it a try

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs

I think this change could use a little more explanation. I also have some ideas for simplifying the code and making it easier to understand. See comments inline. But it looks good to me otherwise. Reviewed-by: Felix Kuehling Regards, Felix On 2017-09-08 08:18 AM,

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs

The hang seems to be gone with this patch. Marek On Fri, Sep 8, 2017 at 2:26 PM, Christian König wrote: > Marek this one will most likely fix your issues with always valid BOs on > Raven. > > Please give it a try when you have time. > > Thanks, > Christian. > > > Am

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs

Marek this one will most likely fix your issues with always valid BOs on Raven. Please give it a try when you have time. Thanks, Christian. Am 08.09.2017 um 14:18 schrieb Christian König: From: Christian König All users of a VM must always wait for updates with

[PATCH] drm/amdgpu: fix VM sync with always valid BOs

From: Christian König All users of a VM must always wait for updates with always valid BOs to be completed. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 14 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c