Re: [PATCH] drm/amdgpu: fix and cleanup amdgpu_gem_object_close v2

2020-03-18 Thread Pan, Xinhui
] drm/amdgpu: fix and cleanup amdgpu_gem_object_close v2 The key point is that 10ms should be sufficient that either the move or the update is finished. One alternative which came to my mind would be to add the exclusive fence as shared as well in this case. This way we won't need to block a

Re: [PATCH] drm/amdgpu: fix and cleanup amdgpu_gem_object_close v2

2020-03-18 Thread Christian König
The key point is that 10ms should be sufficient that either the move or the update is finished. One alternative which came to my mind would be to add the exclusive fence as shared as well in this case. This way we won't need to block at all. Christian. Am 18.03.20 um 09:00 schrieb Pan, Xinh

Re: [PATCH] drm/amdgpu: fix and cleanup amdgpu_gem_object_close v2

2020-03-18 Thread Pan, Xinhui
I wonder if it really fix anything with such small delay. but it should be no harm anyway. Reviewed-by: xinhui pan > 2020年3月18日 15:51,Christian König 写道: > > Ping? Xinhui can I get an rb for this? > > Thanks, > Christian. > > Am 16.03.20 um 14:22 schrieb Christian König: >> The problem is t

Re: [PATCH] drm/amdgpu: fix and cleanup amdgpu_gem_object_close v2

2020-03-18 Thread Christian König
Ping? Xinhui can I get an rb for this? Thanks, Christian. Am 16.03.20 um 14:22 schrieb Christian König: The problem is that we can't add the clear fence to the BO when there is an exclusive fence on it since we can't guarantee the the clear fence will complete after the exclusive one. To fix t

[PATCH] drm/amdgpu: fix and cleanup amdgpu_gem_object_close v2

2020-03-16 Thread Christian König
The problem is that we can't add the clear fence to the BO when there is an exclusive fence on it since we can't guarantee the the clear fence will complete after the exclusive one. To fix this refactor the function and wait for any potential exclusive fence with a small timeout before adding the