> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Flora Cui
> Sent: Thursday, May 18, 2017 11:37 PM
> To: Christian K�nig
> Cc: amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: fix ocl test performance
Reviewed-by: Chunming Zhou
原始邮件
主题：Re: [PATCH] drm/amdgpu: fix ocl test performance drop
发件人：Flora Cui
收件人："Zhou, David(ChunMing)"
抄送：amd-gfx@lists.freedesktop.org
partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
amdgpu_vm_
Am 22.05.2017 um 12:10 schrieb Flora Cui:
partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
amdgpu_vm_flush
Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
Signed-off-by: Flora Cui
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +--
1 file
partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
amdgpu_vm_flush
Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
On 2017年05月22日 16:34, Flora Cui wrote:
partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
amdgpu_vm_flush
Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +++---
1 file changed, 3 insertions(+), 3 dele
partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
amdgpu_vm_flush
Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/am
Could anyone give me a RB?
On Fri, May 19, 2017 at 01:59:16PM +0200, Christian König wrote:
> I'm pretty sure that bug is fixed in GFX9. So we don't need the check there
> any more.
>
> Regards,
> Christian.
>
> Am 19.05.2017 um 07:16 schrieb zhoucm1:
> >I also realized this problem when I did f
See my other comment about simplifying the patch in the other mail:
[flora]: for compute ring & amdgpu_vm_ring_has_compute_vm_bug(), a
vm_flush is
inserted. This might cause performance drop.
Ah, I see. We only need the pipeline sync, but not the vm flush.
In this case I suggest to just change
I'm pretty sure that bug is fixed in GFX9. So we don't need the check
there any more.
Regards,
Christian.
Am 19.05.2017 um 07:16 schrieb zhoucm1:
I also realized this problem when I did fix for sched fence, I thought
if no issue, just left it as current code, it's more safe.
As Flora point it
Am 19.05.2017 um 04:25 schrieb Flora Cui:
On Thu, May 18, 2017 at 01:38:15PM +0200, Christian König wrote:
Am 18.05.2017 um 09:45 schrieb Flora Cui:
partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
amdgpu_vm_flush
Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
Signed-off-by
I also realized this problem when I did fix for sched fence, I thought
if no issue, just left it as current code, it's more safe.
As Flora point it out, it results in performance drop, then we need to
correct it back.
pipeline_sync in vm flush should be inserted only when
amdgpu_vm_ring_has_comp
btw, what's about gfx9 for amdgpu_vm_ring_has_compute_vm_bug()? Is the
workaround still needed?
On Fri, May 19, 2017 at 10:25:19AM +0800, Flora Cui wrote:
> On Thu, May 18, 2017 at 01:38:15PM +0200, Christian König wrote:
> > Am 18.05.2017 um 09:45 schrieb Flora Cui:
> > >partial revert commit <69
On Thu, May 18, 2017 at 01:38:15PM +0200, Christian König wrote:
> Am 18.05.2017 um 09:45 schrieb Flora Cui:
> >partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
> >amdgpu_vm_flush
> >
> >Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
> >Signed-off-by: Flora Cui
>
> I don't see
Am 18.05.2017 um 09:45 schrieb Flora Cui:
partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
amdgpu_vm_flush
Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
Signed-off-by: Flora Cui
I don't see how the revert should be faster than the original.
Especially that amdgpu_vm_had_
partial revert commit <6971d3d> - drm/amdgpu: cleanup logic in
amdgpu_vm_flush
Change-Id: Iadce9d613dfe9a739643a74050cea55854832adb
Signed-off-by: Flora Cui
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/d
15 matches
Mail list logo
