[PATCH] drm/amdgpu: fix the null pointer to get timeline by scheduler fence

2018-08-08 Thread Huang Rui
We won't initialize fence scheduler in drm_sched_fence_create() anymore, so it will refer null fence scheduler if open trace event to get the timeline name. Actually, it is the scheduler name from the entity, so add a macro to replace legacy getting timeline name by job. [ 212.844281] BUG: unable

Re: [PATCH] drm/amdgpu: fix the null pointer to get timeline by scheduler fence

2018-08-08 Thread Christian König
Yeah that is a known issue, but this solution is not correct either. See the scheduler where the job is execute on is simply not determined yet when we want to trace it. So using the scheduler name from the entity is wrong as well. We should probably move the reschedule from drm_sched_entity_

Re: [PATCH] drm/amdgpu: fix the null pointer to get timeline by scheduler fence

2018-08-08 Thread Huang Rui
On Wed, Aug 08, 2018 at 03:10:07PM +0800, Koenig, Christian wrote: > Yeah that is a known issue, but this solution is not correct either. > > See the scheduler where the job is execute on is simply not determined > yet when we want to trace it. > > So using the scheduler name from the entity is

Re: [PATCH] drm/amdgpu: fix the null pointer to get timeline by scheduler fence

2018-08-08 Thread Nayan Deshmukh
On Wed, Aug 8, 2018 at 4:58 PM Huang Rui wrote: > On Wed, Aug 08, 2018 at 03:10:07PM +0800, Koenig, Christian wrote: > > Yeah that is a known issue, but this solution is not correct either. > > > > See the scheduler where the job is execute on is simply not determined > > yet when we want to trac

Re: [PATCH] drm/amdgpu: fix the null pointer to get timeline by scheduler fence

2018-08-09 Thread Huang Rui
On Wed, Aug 08, 2018 at 05:30:17PM +0530, Nayan Deshmukh wrote: > On Wed, Aug 8, 2018 at 4:58 PM Huang Rui wrote: > > > On Wed, Aug 08, 2018 at 03:10:07PM +0800, Koenig, Christian wrote: > > > Yeah that is a known issue, but this solution is not correct either. > > > > > > See the scheduler where

Re: [PATCH] drm/amdgpu: fix the null pointer to get timeline by scheduler fence

2018-08-13 Thread Andres Rodriguez
Any updates on this issue? Regards, Andres On 2018-08-08 03:10 AM, Christian König wrote: Yeah that is a known issue, but this solution is not correct either. See the scheduler where the job is execute on is simply not determined yet when we want to trace it. So using the scheduler name fro

Re: [PATCH] drm/amdgpu: fix the null pointer to get timeline by scheduler fence

2018-08-13 Thread Christian König
That is fixed by "drm/scheduler: bind job earlier to scheduler". Christian. Am 13.08.2018 um 16:33 schrieb Andres Rodriguez: Any updates on this issue? Regards, Andres On 2018-08-08 03:10 AM, Christian König wrote: Yeah that is a known issue, but this solution is not correct either. See the