Re: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled (v2)

2020-08-25 Thread Luben Tuikov
On 2020-08-25 10:34 a.m., Nirmoy wrote: > > On 8/25/20 4:18 PM, Alex Deucher wrote: >> virtual display is non-atomic so report false to avoid checking > > With below nitpick fixed, Acked-by: Nirmoy Das Another nitpick: "below" is not an adjective. It's a preposition or in this case as an

Re: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled (v2)

2020-08-25 Thread Nirmoy
On 8/25/20 4:18 PM, Alex Deucher wrote: virtual display is non-atomic so report false to avoid checking With below nitpick fixed, Acked-by: Nirmoy Das virtual --> Virtual Nirmoy atomic state and other atomic things at runtime. v2: squash into the sr-iov check Signed-off-by: Alex

RE: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled (v2)

2020-08-25 Thread Chen, Guchun
[AMD Public Use] Acked-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, August 25, 2020 10:18 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: report DC not supported if virtual display

[PATCH] drm/amdgpu: report DC not supported if virtual display is enabled (v2)

2020-08-25 Thread Alex Deucher
virtual display is non-atomic so report false to avoid checking atomic state and other atomic things at runtime. v2: squash into the sr-iov check Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled

2020-08-25 Thread Deucher, Alexander
[AMD Public Use] I can do that. Alex From: Chen, Guchun Sent: Tuesday, August 25, 2020 10:13 AM To: Alex Deucher ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled

RE: [PATCH] drm/amdgpu: report DC not supported if virtual display is enabled

2020-08-25 Thread Chen, Guchun
[AMD Public Use] Why not merging it to the same line of SRIOV check? if (amdgpu_sriov_vf(adev) || adev->enable_virtual_display ) return false; Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Tuesday, August 25, 2020 9:45 PM To:

[PATCH] drm/amdgpu: report DC not supported if virtual display is enabled

2020-08-25 Thread Alex Deucher
virtual display is non-atomic so report false to avoid checking atomic state and other atomic things at runtime. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c