Re: [PATCH] drm/amdgpu: revert "fix system hang issue during GPU reset"

2020-08-13 Thread Matt Coffin
On 8/12/20 9:55 AM, Alex Deucher wrote: > This also broke GPU overclocking. The fix for the `pp_od_clk_voltage` interface was actually quite simple, and the bug was limited to that function. The patch just messed up the return value (which was supposed to be the # of bytes consumed). It was just

Re: [PATCH] drm/amdgpu: revert "fix system hang issue during GPU reset"

2020-08-12 Thread Alex Deucher
On Wed, Aug 12, 2020 at 11:54 AM Christian König wrote: > > The whole approach wasn't thought through till the end. > > We already had a reset lock like this in the past and it caused the same > problems like this one. > > Completely revert the patch for now and add individual trylock protection

[PATCH] drm/amdgpu: revert "fix system hang issue during GPU reset"

2020-08-12 Thread Christian König
The whole approach wasn't thought through till the end. We already had a reset lock like this in the past and it caused the same problems like this one. Completely revert the patch for now and add individual trylock protection to the hardware access functions as necessary. This reverts commit