RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic

2020-06-05 Thread Gao, Likun
- From: Zhang, Hawking Sent: Friday, June 5, 2020 10:14 PM To: Gao, Likun ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei Subject: RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic [AMD Public Use] It looks more reasonable to me to move the AISC type check to the following

RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic

2020-06-05 Thread Zhang, Hawking
ing -Original Message- From: Zhang, Hawking Sent: Friday, June 5, 2020 22:10 To: Zhang, Hawking ; Gao, Likun ; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei Subject: RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic [AMD Public Use] Wait, I see the risk. the amdgpu_ttm_i

RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic

2020-06-05 Thread Zhang, Hawking
; amd-gfx@lists.freedesktop.org Cc: Xu, Feifei Subject: RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic [AMD Public Use] Does it mean there is legacy VBIOS that even doesn't have firmwareinfo table and introduce crash? I think we expect the atomfirmware interface return 0

RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic

2020-06-05 Thread Zhang, Hawking
21:04 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xu, Feifei ; Gao, Likun Subject: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic From: Likun Gao Skip for reserved fb size query for the ASIC older than navi10, as those asic do not need for TMR region reserve

[PATCH] drm/amdgpu: skip fb size query for navi10 previous asic

2020-06-05 Thread Likun Gao
From: Likun Gao Skip for reserved fb size query for the ASIC older than navi10, as those asic do not need for TMR region reserve and may get an invalid value. Signed-off-by: Likun Gao Change-Id: Idbc57805b8070f27ba6c3cf22f1892d6dab92f06 --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 3