RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3

2019-04-10 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of > Yintian Tao > Sent: Wednesday, April 10, 2019 10:26 PM > To: amd-gfx@lists.freedesktop.org > Cc: Tao, Yintian > Subject: [PATCH] drm/amdgpu: support dpm level modification under > virt

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Kuehling, Felix
: amd-gfx On Behalf Of Yintian Tao Sent: Tuesday, April 9, 2019 11:18 To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amdgpu: support dpm level modification under virtualization Under vega10 virtualuzation, smu ip block will not be added. Therefore, we need add pp clk query

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3

2019-04-10 Thread Tao, Yintian
Hi Alex Many thanks for your review. Best Regards Yintian Tao -Original Message- From: Alex Deucher Sent: Wednesday, April 10, 2019 11:32 PM To: Tao, Yintian Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3 On Wed, Apr 10

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization v3

2019-04-10 Thread Alex Deucher
On Wed, Apr 10, 2019 at 10:25 AM Yintian Tao wrote: > > Under vega10 virtualuzation, smu ip block will not be added. > Therefore, we need add pp clk query and force dpm level function > at amdgpu_virt_ops to support the feature. > > v2: add get_pp_clk existence check and use kzalloc to allocate

[PATCH] drm/amdgpu: support dpm level modification under virtualization v3

2019-04-10 Thread Yintian Tao
Under vega10 virtualuzation, smu ip block will not be added. Therefore, we need add pp clk query and force dpm level function at amdgpu_virt_ops to support the feature. v2: add get_pp_clk existence check and use kzalloc to allocate buf v3: return -ENOMEM for allocation failure and correct the

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization v2

2019-04-10 Thread Tao, Yintian
Hi Christian Many thanks for your review. I will correct the patch by v3 Best Regards Yintian Tao -Original Message- From: Christian König Sent: Wednesday, April 10, 2019 10:02 PM To: Tao, Yintian ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: support dpm level

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization v2

2019-04-10 Thread Christian König
Am 10.04.19 um 15:02 schrieb Yintian Tao: Under vega10 virtualuzation, smu ip block will not be added. Therefore, we need add pp clk query and force dpm level function at amdgpu_virt_ops to support the feature. v2: add get_pp_clk existence check and use kzalloc to allocate buf Change-Id:

[PATCH] drm/amdgpu: support dpm level modification under virtualization v2

2019-04-10 Thread Yintian Tao
Under vega10 virtualuzation, smu ip block will not be added. Therefore, we need add pp clk query and force dpm level function at amdgpu_virt_ops to support the feature. v2: add get_pp_clk existence check and use kzalloc to allocate buf Change-Id: I713419c57b854082f6f739f1d32a055c7115e620

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Sent: Wednesday, April 10, 2019 8:23 PM To: Tao, Yintian ; Quan, Evan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization Hi Yintian, yeah, kzalloc would obvious work. But why do you need such a large buffer in the first place

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Koenig, Christian
> -Original Message- > From: Christian König > Sent: Wednesday, April 10, 2019 6:32 PM > To: Quan, Evan ; Tao, Yintian ; > amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: support dpm level modification under > virtualization > > Am 10.04.19 um 11:58 s

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Sent: Wednesday, April 10, 2019 6:32 PM To: Quan, Evan ; Tao, Yintian ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization Am 10.04.19 um 11:58 schrieb Quan, Evan: > >> -Original Message- >> From: amd

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Christian König
Am 10.04.19 um 11:58 schrieb Quan, Evan: -Original Message- From: amd-gfx On Behalf Of Yintian Tao Sent: 2019年4月9日 23:18 To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amdgpu: support dpm level modification under virtualization Under vega10 virtualuzation

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
Subject: RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization > -Original Message- > From: amd-gfx On Behalf Of > Yintian Tao > Sent: 2019年4月9日 23:18 > To: amd-gfx@lists.freedesktop.org > Cc: Tao, Yintian > Subject: [PATCH] drm/amdgpu: support d

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Quan, Evan
> -Original Message- > From: amd-gfx On Behalf Of > Yintian Tao > Sent: 2019年4月9日 23:18 > To: amd-gfx@lists.freedesktop.org > Cc: Tao, Yintian > Subject: [PATCH] drm/amdgpu: support dpm level modification under > virtualization > > Under vega1

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
t: Tuesday, April 09, 2019 11:18 PM > To: amd-gfx@lists.freedesktop.org > Cc: Tao, Yintian > Subject: [PATCH] drm/amdgpu: support dpm level modification under > virtualization > > Under vega10 virtualuzation, smu ip block will not be added. > Therefore, we need add pp clk q

Re: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Koenig, Christian
top.org > Cc: Tao, Yintian > Subject: [PATCH] drm/amdgpu: support dpm level modification under > virtualization > > Under vega10 virtualuzation, smu ip block will not be added. > Therefore, we need add pp clk query and force dpm level funct

RE: [PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-10 Thread Tao, Yintian
: support dpm level modification under virtualization Under vega10 virtualuzation, smu ip block will not be added. Therefore, we need add pp clk query and force dpm level function at amdgpu_virt_ops to support the feature. Change-Id: I713419c57b854082f6f739f1d32a055c7115e620 Signed-off-by: Yintian Tao

[PATCH] drm/amdgpu: support dpm level modification under virtualization

2019-04-09 Thread Yintian Tao
Under vega10 virtualuzation, smu ip block will not be added. Therefore, we need add pp clk query and force dpm level function at amdgpu_virt_ops to support the feature. Change-Id: I713419c57b854082f6f739f1d32a055c7115e620 Signed-off-by: Yintian Tao --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c