Re: [PATCH] drm/amdkfd: Disable Packet Manager in non HWS mode except Hawaii

2019-04-17 Thread Zhao, Yong
Okay, I will abandon it. Yong On 2019-04-17 5:44 p.m., Kuehling, Felix wrote: > If you want to optimize driver init time, you should check what actually > takes the most time. Randomly micro-optimizing things that may not even > matter only increases complexity for no benefit. > > Typically the

Re: [PATCH] drm/amdkfd: Disable Packet Manager in non HWS mode except Hawaii

2019-04-17 Thread Kuehling, Felix
If you want to optimize driver init time, you should check what actually takes the most time. Randomly micro-optimizing things that may not even matter only increases complexity for no benefit. Typically the things that make initialization slow are points where we synchronize with the GPU or

Re: [PATCH] drm/amdkfd: Disable Packet Manager in non HWS mode except Hawaii

2019-04-17 Thread Zhao, Yong
I can fix that cosmetic line. I did not measure the difference, but driver initialization usually takes a longer time, that's why I am trying to reduce it. Also, it means one less thing to worry about during non HWS mode bringup, because we don't need to deal with HIQ any more. With that, what

Re: [PATCH] drm/amdkfd: Disable Packet Manager in non HWS mode except Hawaii

2019-04-17 Thread Kuehling, Felix
On 2019-04-17 4:54 p.m., Zhao, Yong wrote: > The packet manager is only needed for HWS mode, as well as Hawaii in non > HWS mode. So only initialize it under those scenarios. This is useful > especially for emulation environment when things are slow. I never thought of packet manager

[PATCH] drm/amdkfd: Disable Packet Manager in non HWS mode except Hawaii

2019-04-17 Thread Zhao, Yong
The packet manager is only needed for HWS mode, as well as Hawaii in non HWS mode. So only initialize it under those scenarios. This is useful especially for emulation environment when things are slow. Change-Id: Iedfa07c94241e3252463e1e5ea537543c2ccef03 Signed-off-by: Yong Zhao ---