Re: [PATCH] drm/amdkfd: Fix an inappropriate error handling in allloc memory of gpu

2021-10-13 Thread Felix Kuehling
Am 2021-10-13 um 3:28 a.m. schrieb Lang Yu: > We should unreference a gem object instead of an amdgpu bo here. > > Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD") I think the Fixes tag is incorrect. At that time there was no gobj in this function. If anything I'd attribute the p

Re: [PATCH] drm/amdkfd: Fix an inappropriate error handling in allloc memory of gpu

2021-10-13 Thread Das, Nirmoy
LGTM as we create a gem object 1st and retrieve amdgpu_bo from the gem object. Acked-by: Nirmoy Das On 10/13/2021 9:28 AM, Lang Yu wrote: We should unreference a gem object instead of an amdgpu bo here. Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD") Signed-off-by: Lang Yu

[PATCH] drm/amdkfd: Fix an inappropriate error handling in allloc memory of gpu

2021-10-13 Thread Lang Yu
We should unreference a gem object instead of an amdgpu bo here. Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD") Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/am