Re: [PATCH] drm/amdkfd: Fix some issues at userptr buffer validation process.

2023-04-19 Thread Chen, Xiaogang
On 4/18/2023 6:17 PM, Felix Kuehling wrote: On 2023-04-13 23:27, Chen, Xiaogang wrote: On 4/13/2023 3:08 PM, Felix Kuehling wrote: Am 2023-04-12 um 02:14 schrieb Xiaogang.Chen: From: Xiaogang Chen Notice userptr buffer restore process has following issues: 1:

Re: [PATCH] drm/amdkfd: Fix some issues at userptr buffer validation process.

2023-04-18 Thread Felix Kuehling
On 2023-04-13 23:27, Chen, Xiaogang wrote: On 4/13/2023 3:08 PM, Felix Kuehling wrote: Am 2023-04-12 um 02:14 schrieb Xiaogang.Chen: From: Xiaogang Chen Notice userptr buffer restore process has following issues: 1: amdgpu_ttm_tt_get_user_pages can fail(-EFAULT). If it failed we should

Re: [PATCH] drm/amdkfd: Fix some issues at userptr buffer validation process.

2023-04-13 Thread Chen, Xiaogang
On 4/13/2023 3:08 PM, Felix Kuehling wrote: Am 2023-04-12 um 02:14 schrieb Xiaogang.Chen: From: Xiaogang Chen Notice userptr buffer restore process has following issues: 1: amdgpu_ttm_tt_get_user_pages can fail(-EFAULT). If it failed we should not set it valid(mem->invalid = 0). In this

Re: [PATCH] drm/amdkfd: Fix some issues at userptr buffer validation process.

2023-04-13 Thread Felix Kuehling
Am 2023-04-12 um 02:14 schrieb Xiaogang.Chen: From: Xiaogang Chen Notice userptr buffer restore process has following issues: 1: amdgpu_ttm_tt_get_user_pages can fail(-EFAULT). If it failed we should not set it valid(mem->invalid = 0). In this case mem has no associated hmm range or

[PATCH] drm/amdkfd: Fix some issues at userptr buffer validation process.

2023-04-12 Thread Xiaogang . Chen
From: Xiaogang Chen Notice userptr buffer restore process has following issues: 1: amdgpu_ttm_tt_get_user_pages can fail(-EFAULT). If it failed we should not set it valid(mem->invalid = 0). In this case mem has no associated hmm range or user_pages associated. 2: mmu notifier can happen