Re: [PATCH] drm/amdkfd: Replace one-element array with flexible-array member

2022-02-18 Thread Christian König
Well in that case somebody could argue that we should probably remove the structure altogether. Regards, Christian. Am 18.02.22 um 17:15 schrieb Felix Kuehling: It looks like this structure isn't being used at all. So I'm OK with this change, in case we ever use it in the future. Regards,  

Re: [PATCH] drm/amdkfd: Replace one-element array with flexible-array member

2022-02-18 Thread Felix Kuehling
It looks like this structure isn't being used at all. So I'm OK with this change, in case we ever use it in the future. Regards,   Felix Am 2022-02-18 um 02:47 schrieb Christian König: Felix need to comment as well, but I don't think that this will work that easily. By changing the entry fr

[PATCH] drm/amdkfd: Replace one-element array with flexible-array member

2022-02-18 Thread cgel . zte
From: Changcheng Deng There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members" for these cases. The older style of one-element or zero-length arrays should no longer

Re: [PATCH] drm/amdkfd: Replace one-element array with flexible-array member

2022-02-17 Thread Christian König
Felix need to comment as well, but I don't think that this will work that easily. By changing the entry from 1 to 0 your are also changing the size of the structure. Regards, Christian. Am 18.02.22 um 04:09 schrieb cgel@gmail.com: From: Changcheng Deng There is a regular need in the k