RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kuehling, Felix > Sent: Wednesday, June 7, 2023 6:23 PM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Huang, JinHuiEric > Subject: Re: [PATCH] drm/amdkfd: fix and enable debugging for gfx11 > > > On 2023-06-0

Re: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Felix Kuehling
On 2023-06-07 16:20, Jonathan Kim wrote: There are a couple of fixes required to enable gfx11 debugging. First, ADD_QUEUE.trap_en is an inappropriate place to toggle a per-process register so move it to SET_SHADER_DEBUGGER.trap_en. When ADD_QUEUE.skip_process_ctx_clear is set, MES will priorit

[PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Jonathan Kim
There are a couple of fixes required to enable gfx11 debugging. First, ADD_QUEUE.trap_en is an inappropriate place to toggle a per-process register so move it to SET_SHADER_DEBUGGER.trap_en. When ADD_QUEUE.skip_process_ctx_clear is set, MES will prioritize the SET_SHADER_DEBUGGER.trap_en setting.

RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kim, Jonathan > Sent: Wednesday, June 7, 2023 3:28 PM > To: Kuehling, Felix ; amd- > g...@lists.freedesktop.org > Cc: Huang, JinHuiEric > Subject: RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11 > >

RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Kim, Jonathan
[Public] > -Original Message- > From: Kuehling, Felix > Sent: Wednesday, June 7, 2023 2:20 PM > To: amd-gfx@lists.freedesktop.org; Kim, Jonathan > Cc: Huang, JinHuiEric > Subject: Re: [PATCH] drm/amdkfd: fix and enable debugging for gfx11 > > > On 2023-06-0

Re: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Felix Kuehling
On 2023-06-07 13:26, Jonathan Kim wrote: There are a few fixes required to enable gfx11 debugging. First, ADD_QUEUE.trap_en is an inappropriate place to toggle a per-process register so move it to SET_SHADER_DEBUGGER.trap_en. When ADD_QUEUE.skip_process_ctx_clear is set, MES will prioritize th

RE: [PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Kim, Jonathan
[Public] + Felix (typo on email) > -Original Message- > From: Kim, Jonathan > Sent: Wednesday, June 7, 2023 1:27 PM > To: amd-gfx@lists.freedesktop.org > Cc: felix.kuel...@amd.com; Huang, JinHuiEric ; > Kim, Jonathan > Subject: [PATCH] drm/amdkfd: fix and enabl

[PATCH] drm/amdkfd: fix and enable debugging for gfx11

2023-06-07 Thread Jonathan Kim
There are a few fixes required to enable gfx11 debugging. First, ADD_QUEUE.trap_en is an inappropriate place to toggle a per-process register so move it to SET_SHADER_DEBUGGER.trap_en. When ADD_QUEUE.skip_process_ctx_clear is set, MES will prioritize the SET_SHADER_DEBUGGER.trap_en setting. Secon