Re: [PATCH] drm/amdkfd: fix no atomics settings in the kfd topology

2021-05-03 Thread Zeng, Oak
Reviewed-by: Oak Zeng Regards, Oak On 2021-05-03, 3:49 PM, "amd-gfx on behalf of Jonathan Kim" wrote: To account for various PCIe and xGMI setups, check the no atomics settings for a device in relation to every direct peer. v2: apply suggested clean ups in main loop.

Re: [PATCH] drm/amdkfd: fix no atomics settings in the kfd topology

2021-05-03 Thread Felix Kuehling
Am 2021-05-03 um 3:49 p.m. schrieb Jonathan Kim: > To account for various PCIe and xGMI setups, check the no atomics settings > for a device in relation to every direct peer. > > v2: apply suggested clean ups in main loop. > > Signed-off-by: Jonathan Kim Reviewed-by: Felix Kuehling > --- >

[PATCH] drm/amdkfd: fix no atomics settings in the kfd topology

2021-05-03 Thread Jonathan Kim
To account for various PCIe and xGMI setups, check the no atomics settings for a device in relation to every direct peer. v2: apply suggested clean ups in main loop. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 61 ++- 1 file changed, 37

Re: [PATCH] drm/amdkfd: fix no atomics settings in the kfd topology

2021-05-03 Thread Felix Kuehling
Am 2021-05-03 um 11:57 a.m. schrieb Jonathan Kim: > To account for various PCIe and xGMI setups, check the no atomics settings > for a device in relation to every direct peer. Thanks, this looks reasonable. Some more nit-picks about naming and coding style inline. > > Signed-off-by: Jonathan

[PATCH] drm/amdkfd: fix no atomics settings in the kfd topology

2021-05-03 Thread Jonathan Kim
To account for various PCIe and xGMI setups, check the no atomics settings for a device in relation to every direct peer. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 55 ++- 1 file changed, 34 insertions(+), 21 deletions(-) diff --git