Re: [PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-22 Thread Felix Kuehling
Am 2021-04-22 um 10:47 a.m. schrieb Alex Sierra: > SVM ranges are created for unregistered memory, triggered > by page faults. These ranges are migrated/mapped to > GPU VRAM memory. > > Signed-off-by: Alex Sierra > --- > drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 107 ++- >

Re: [PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-22 Thread philip yang
On 2021-04-22 9:20 a.m., Felix Kuehling wrote: Am 2021-04-22 um 9:08 a.m. schrieb philip yang: On 2021-04-20 9:25 p.m., Felix Kuehling wrote: @@ -2251,14 +2330,34 @@ svm_range_restore_pages(struct amdgpu_device *adev, unsigned int pasid,

[PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-22 Thread Alex Sierra
SVM ranges are created for unregistered memory, triggered by page faults. These ranges are migrated/mapped to GPU VRAM memory. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 107 ++- 1 file changed, 104 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-22 Thread Felix Kuehling
Am 2021-04-22 um 9:08 a.m. schrieb philip yang: > > > On 2021-04-20 9:25 p.m., Felix Kuehling wrote: > @@ -2251,14 +2330,34 @@ svm_range_restore_pages(struct amdgpu_device > *adev, unsigned int pasid, } mmap_read_lock(mm); +retry_write_locked: mutex_lock(>lock);

Re: [PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-22 Thread philip yang
On 2021-04-20 9:25 p.m., Felix Kuehling wrote: Am 2021-04-20 um 8:45 p.m. schrieb Felix Kuehling: Am 2021-04-19 um 9:52 p.m. schrieb Alex Sierra: SVM ranges are created for unregistered memory, triggered by page faults.

Re: [PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-20 Thread Felix Kuehling
Am 2021-04-20 um 8:45 p.m. schrieb Felix Kuehling: > Am 2021-04-19 um 9:52 p.m. schrieb Alex Sierra: >> SVM ranges are created for unregistered memory, triggered >> by page faults. These ranges are migrated/mapped to >> GPU VRAM memory. >> >> Signed-off-by: Alex Sierra > This looks generally

Re: [PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-20 Thread Felix Kuehling
Am 2021-04-19 um 9:52 p.m. schrieb Alex Sierra: > SVM ranges are created for unregistered memory, triggered > by page faults. These ranges are migrated/mapped to > GPU VRAM memory. > > Signed-off-by: Alex Sierra This looks generally good to me. One more nit-pick inline in addition to Philip's

Re: [PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-20 Thread philip yang
On 2021-04-19 9:52 p.m., Alex Sierra wrote: SVM ranges are created for unregistered memory, triggered by page faults. These ranges are migrated/mapped to GPU VRAM memory. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 103

[PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-19 Thread Alex Sierra
SVM ranges are created for unregistered memory, triggered by page faults. These ranges are migrated/mapped to GPU VRAM memory. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 103 ++- 1 file changed, 101 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-19 Thread Felix Kuehling
Am 2021-04-19 um 1:24 p.m. schrieb Alex Sierra: > SVM ranges are created for unregistered memory, triggered > by page faults. These ranges are migrated/mapped to > GPU VRAM memory. > > Signed-off-by: Alex Sierra > --- > drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 85 +++- > 1

[PATCH] drm/amdkfd: svm ranges creation for unregistered memory

2021-04-19 Thread Alex Sierra
SVM ranges are created for unregistered memory, triggered by page faults. These ranges are migrated/mapped to GPU VRAM memory. Signed-off-by: Alex Sierra --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 85 +++- 1 file changed, 82 insertions(+), 3 deletions(-) diff --git