Re: [PATCH] drm/display: fix possible null-pointer dereference in dcn10_set_clock()

2021-08-10 Thread Tuo Li
; Lee, Alvin ; Stempen, Vladimir ; isabel.zh...@amd.com; Lee, Sung ; Po-Yu Hsieh Paul ; Wood, Wyatt Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org; baijiaju1...@gmail.com; Tuo Li ; TOTE Robot Subject: [PATCH] drm/display: fix possible null-pointe

RE: [PATCH] drm/display: fix possible null-pointer dereference in dcn10_set_clock()

2021-08-10 Thread Chen, Guchun
lists.freedesktop.org; linux-ker...@vger.kernel.org; baijiaju1...@gmail.com; Tuo Li ; TOTE Robot Subject: [PATCH] drm/display: fix possible null-pointer dereference in dcn10_set_clock() The variable dc->clk_mgr is checked in: if (dc->clk_mgr && dc->clk_mgr->funcs->get

[PATCH] drm/display: fix possible null-pointer dereference in dcn10_set_clock()

2021-08-10 Thread Tuo Li
The variable dc->clk_mgr is checked in: if (dc->clk_mgr && dc->clk_mgr->funcs->get_clock) This indicates dc->clk_mgr can be NULL. However, it is dereferenced in: if (!dc->clk_mgr->funcs->get_clock) To fix this possible null-pointer dereference, check dc->clk_mgr before dereferencing it.