Re: [PATCH] drm/powerplay: print current clock level when dpm is disabled on vg20

2019-02-19 Thread Liu, Shaoyun
Oh, already submitted.  I use the same  return error code(-1) as used in the same function for other asic (vega12) .  BTW , the original -EPERM is defined as -1 , so they shouldn't make any real difference.  Maybe later we use a separate change of the return code for all the existing asic . Re

Re: [PATCH] drm/powerplay: print current clock level when dpm is disabled on vg20

2019-02-19 Thread Kuehling, Felix
On 2019-02-19 4:09 p.m., Liu, Shaoyun wrote: > When DPM for the specific clock is difabled, driver should still print out > current clock info for rocm-smi support on vega20 > > Change-Id: I8669c77bf153caa2cd63a575802eb58747151239 > Signed-off-by: shaoyunl > --- > drivers/gpu/drm/amd/powerplay/h

Re: [PATCH] drm/powerplay: print current clock level when dpm is disabled on vg20

2019-02-19 Thread Huang, JinHuiEric
Typo "difabled" -> "disabled" in description. With that fix it is Reviewed-by: Eric Huang On 2019-02-19 4:09 p.m., Liu, Shaoyun wrote: > When DPM for the specific clock is difabled, driver should still print out > current clock info for rocm-smi support on vega20 > > Change-Id: I8669c77bf153caa2

[PATCH] drm/powerplay: print current clock level when dpm is disabled on vg20

2019-02-19 Thread Liu, Shaoyun
When DPM for the specific clock is difabled, driver should still print out current clock info for rocm-smi support on vega20 Change-Id: I8669c77bf153caa2cd63a575802eb58747151239 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 56 +++--- 1 file cha