Re: [PATCH] drm/radeon/r100: enhance error handling in r100_cp_init_microcode

2024-05-28 Thread Zhouyi Zhou
Fix some error in my previous email On Tue, May 28, 2024 at 9:36 AM Zhouyi Zhou wrote: > > Thanks for reviewing the patch > > On Mon, May 27, 2024 at 3:58 PM Christian König > wrote: > > > > Am 27.05.24 um 03:20 schrieb Zhouyi Zhou: > > > In r100_cp_init_microcode, if rdev->family don't match

Re: [PATCH] drm/radeon/r100: enhance error handling in r100_cp_init_microcode

2024-05-28 Thread Zhouyi Zhou
Thanks for reviewing the patch On Mon, May 27, 2024 at 3:58 PM Christian König wrote: > > Am 27.05.24 um 03:20 schrieb Zhouyi Zhou: > > In r100_cp_init_microcode, if rdev->family don't match any of > > if statement, fw_name will be NULL, which will cause > > gcc (11.4.0 powerpc64le-linux-gnu)

[PATCH] drm/radeon/r100: enhance error handling in r100_cp_init_microcode

2024-05-27 Thread Zhouyi Zhou
In r100_cp_init_microcode, if rdev->family don't match any of if statement, fw_name will be NULL, which will cause gcc (11.4.0 powerpc64le-linux-gnu) complain: In function ‘r100_cp_init_microcode’, inlined from ‘r100_cp_init’ at drivers/gpu/drm/radeon/r100.c:1136:7:

Re: [PATCH] drm/radeon/r100: enhance error handling in r100_cp_init_microcode

2024-05-27 Thread Christian König
Am 27.05.24 um 03:20 schrieb Zhouyi Zhou: In r100_cp_init_microcode, if rdev->family don't match any of if statement, fw_name will be NULL, which will cause gcc (11.4.0 powerpc64le-linux-gnu) complain: In function ‘r100_cp_init_microcode’, inlined from ‘r100_cp_init’ at