Re: [PATCH] drm/radeon: cleanup coding style a bit

2020-04-30 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Apr 26, 2020 at 9:18 AM Christian König wrote: > > Am 26.04.20 um 15:12 schrieb Bernard Zhao: > > Maybe no need to check ws before kmalloc, kmalloc will check > > itself, kmalloc`s logic is if ptr is NULL, kmalloc will just > > return > > > > Signed-off-by: Bernard

Re: [PATCH] drm/radeon: cleanup coding style a bit

2020-04-30 Thread Christian König
@vger.kernel.org 抄送人:opensource.ker...@vivo.com 主题:Re: [PATCH] drm/radeon: cleanup coding style a bit>On Sun, 2020-04-26 at 15:18 +0200, Christian König wrote: Am 26.04.20 um 15:12 schrieb Bernard Zhao: Maybe no need to check ws before kmalloc, kmalloc will check itself, kmalloc`s logic is if ptr is

Re:Re: [PATCH] drm/radeon: cleanup coding style a bit

2020-04-30 Thread Bernard
m 主题:Re: [PATCH] drm/radeon: cleanup coding style a bit>On Sun, 2020-04-26 at 15:18 +0200, Christian König wrote: >> Am 26.04.20 um 15:12 schrieb Bernard Zhao: >> > Maybe no need to check ws before kmalloc, kmalloc will check >> > itself, kmalloc`s logic is if ptr is NULL, kmal

Re: [PATCH] drm/radeon: cleanup coding style a bit

2020-04-27 Thread Joe Perches
On Sun, 2020-04-26 at 15:18 +0200, Christian König wrote: > Am 26.04.20 um 15:12 schrieb Bernard Zhao: > > Maybe no need to check ws before kmalloc, kmalloc will check > > itself, kmalloc`s logic is if ptr is NULL, kmalloc will just > > return > > > > Signed-off-by: Bernard Zhao > > Reviewed-by:

[PATCH] drm/radeon: cleanup coding style a bit

2020-04-27 Thread Bernard Zhao
Maybe no need to check ws before kmalloc, kmalloc will check itself, kmalloc`s logic is if ptr is NULL, kmalloc will just return Signed-off-by: Bernard Zhao --- drivers/gpu/drm/radeon/atom.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/dri

Re: [PATCH] drm/radeon: cleanup coding style a bit

2020-04-27 Thread Joe Perches
btw: the debugging macros in atom.c are not good. It could be something like the below as the output logging is at best poorly formatted due to the many individual printks without KERN_ that are emitted on separate lines. #define ATOM_DEBUG should probably be commented out. The debugging macro

Re: [PATCH] drm/radeon: cleanup coding style a bit

2020-04-26 Thread Christian König
Am 26.04.20 um 15:12 schrieb Bernard Zhao: Maybe no need to check ws before kmalloc, kmalloc will check itself, kmalloc`s logic is if ptr is NULL, kmalloc will just return Signed-off-by: Bernard Zhao Reviewed-by: Christian König I'm wondering why the automated scripts haven't found that one