Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-05 Thread Christian König
Yeah, I realized that as well after sending the first mail. The problem is that we keep the bulk move around when there currently isn't any resource associated with the template. So the correct code should look something like this: if (fbo->base.resource) {    

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-05 Thread Yin, ZhenGuo (Chris)
Inside the function ttm_bo_set_bulk_move, it calls ttm_resource_del_bulk_move to remove the old resource from the bulk_move list. If we set the bulk_move to NULL manually as suggested, the old resource attached in the ghost BO seems won't be removed from the bulk_move. On 9/1/2022 7:13 PM,

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread Christian König
Am 01.09.22 um 13:11 schrieb Christian König: Am 01.09.22 um 11:29 schrieb ZhenGuo Yin: [Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace:   

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread Christian König
Am 01.09.22 um 11:29 schrieb ZhenGuo Yin: [Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace: amddma_resv_reserve_fences+0x10d/0x1f0 [amdkcl]

Re: [PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread JingWen Chen
Acked-by: Jingwen Chen still need confirmation from Christian On 9/1/22 5:29 PM, ZhenGuo Yin wrote: > [Why] > Ghost BO is released with non-empty bulk move object. There is a > warning trace: > WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 > [amdttm] > Call Trace: >

[PATCH] drm/ttm: update bulk move object of ghost BO

2022-09-01 Thread ZhenGuo Yin
[Why] Ghost BO is released with non-empty bulk move object. There is a warning trace: WARNING: CPU: 19 PID: 1582 at ttm/ttm_bo.c:366 ttm_bo_release+0x2e1/0x2f0 [amdttm] Call Trace: amddma_resv_reserve_fences+0x10d/0x1f0 [amdkcl] amdttm_bo_put+0x28/0x30 [amdttm]