Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-24 Thread Dave Chinner
On Sun, Jun 21, 2020 at 01:42:05PM -0400, Qian Cai wrote: > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > > fs_reclaim_acquire/release nicely catch recursion issues when > > allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend > > to use to keep the excessive

Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-24 Thread Qian Cai
> On Jun 23, 2020, at 6:13 PM, Daniel Vetter wrote: > > Ok I tested this. I can't use your script to repro because > - I don't have a setup with xfs, and the splat points at an issue in xfs > - reproducing lockdep splats in shrinker callbacks is always a bit tricky What’s xfs setup are you

Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-23 Thread Daniel Vetter
On Wed, Jun 24, 2020 at 12:31 AM Dave Chinner wrote: > > On Sun, Jun 21, 2020 at 01:42:05PM -0400, Qian Cai wrote: > > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > > > fs_reclaim_acquire/release nicely catch recursion issues when > > > allocating GFP_KERNEL memory against

Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2020 at 6:18 PM Qian Cai wrote: > > On Sun, Jun 21, 2020 at 10:01:03PM +0200, Daniel Vetter wrote: > > On Sun, Jun 21, 2020 at 08:07:08PM +0200, Daniel Vetter wrote: > > > On Sun, Jun 21, 2020 at 7:42 PM Qian Cai wrote: > > > > > > > > On Wed, Jun 10, 2020 at 09:41:01PM +0200,

Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-23 Thread Qian Cai
On Sun, Jun 21, 2020 at 10:01:03PM +0200, Daniel Vetter wrote: > On Sun, Jun 21, 2020 at 08:07:08PM +0200, Daniel Vetter wrote: > > On Sun, Jun 21, 2020 at 7:42 PM Qian Cai wrote: > > > > > > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > > > > fs_reclaim_acquire/release nicely

Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-22 Thread Qian Cai
On Sun, Jun 21, 2020 at 10:01:03PM +0200, Daniel Vetter wrote: > On Sun, Jun 21, 2020 at 08:07:08PM +0200, Daniel Vetter wrote: > > On Sun, Jun 21, 2020 at 7:42 PM Qian Cai wrote: > > > > > > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > > > > fs_reclaim_acquire/release nicely

Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-22 Thread Qian Cai
On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > fs_reclaim_acquire/release nicely catch recursion issues when > allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend > to use to keep the excessive caches in check). For mmu notifier > recursions we do have lockdep

Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-21 Thread Daniel Vetter
On Sun, Jun 21, 2020 at 08:07:08PM +0200, Daniel Vetter wrote: > On Sun, Jun 21, 2020 at 7:42 PM Qian Cai wrote: > > > > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > > > fs_reclaim_acquire/release nicely catch recursion issues when > > > allocating GFP_KERNEL memory against

Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-21 Thread Daniel Vetter
On Sun, Jun 21, 2020 at 7:42 PM Qian Cai wrote: > > On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > > fs_reclaim_acquire/release nicely catch recursion issues when > > allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend > > to use to keep the excessive caches

Re: [PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-11 Thread Jason Gunthorpe
On Wed, Jun 10, 2020 at 09:41:01PM +0200, Daniel Vetter wrote: > fs_reclaim_acquire/release nicely catch recursion issues when > allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend > to use to keep the excessive caches in check). For mmu notifier > recursions we do have lockdep

[PATCH] mm: Track mmu notifiers in fs_reclaim_acquire/release

2020-06-10 Thread Daniel Vetter
fs_reclaim_acquire/release nicely catch recursion issues when allocating GFP_KERNEL memory against shrinkers (which gpu drivers tend to use to keep the excessive caches in check). For mmu notifier recursions we do have lockdep annotations since 23b68395c7c7 ("mm/mmu_notifiers: add a lockdep map