Re: [PATCH 00/13] shadow page table support

2016-08-05 Thread Christian König
Am 05.08.2016 um 11:12 schrieb zhoucm1: On 2016年08月05日 16:56, Christian König wrote: Am 05.08.2016 um 04:43 schrieb zhoucm1: On 2016年08月04日 17:52, Christian König wrote: Am 04.08.2016 um 08:05 schrieb zhoucm1: On 2016年08月03日 21:39, Christian König wrote: Doubling all the page table upda

Re: [PATCH 00/13] shadow page table support

2016-08-05 Thread zhoucm1
On 2016年08月05日 16:56, Christian König wrote: Am 05.08.2016 um 04:43 schrieb zhoucm1: On 2016年08月04日 17:52, Christian König wrote: Am 04.08.2016 um 08:05 schrieb zhoucm1: On 2016年08月03日 21:39, Christian König wrote: Doubling all the page table updates clearly doesn't sound like a good id

Re: [PATCH 00/13] shadow page table support

2016-08-05 Thread zhoucm1
On 2016年08月05日 16:56, Christian König wrote: Am 05.08.2016 um 04:43 schrieb zhoucm1: On 2016年08月04日 17:52, Christian König wrote: Am 04.08.2016 um 08:05 schrieb zhoucm1: On 2016年08月03日 21:39, Christian König wrote: Doubling all the page table updates clearly doesn't sound like a good id

Re: [PATCH 00/13] shadow page table support

2016-08-05 Thread Christian König
Am 05.08.2016 um 04:43 schrieb zhoucm1: On 2016年08月04日 17:52, Christian König wrote: Am 04.08.2016 um 08:05 schrieb zhoucm1: On 2016年08月03日 21:39, Christian König wrote: Doubling all the page table updates clearly doesn't sound like a good idea to me. Could you tell me why it isn't a good

Re: [PATCH 00/13] shadow page table support

2016-08-04 Thread zhoucm1
On 2016年08月04日 17:52, Christian König wrote: Am 04.08.2016 um 08:05 schrieb zhoucm1: On 2016年08月03日 21:39, Christian König wrote: Doubling all the page table updates clearly doesn't sound like a good idea to me. Could you tell me why it isn't a good idea? I though the overhead is the least

Re: [PATCH 00/13] shadow page table support

2016-08-04 Thread Christian König
Am 04.08.2016 um 08:05 schrieb zhoucm1: On 2016年08月03日 21:39, Christian König wrote: Doubling all the page table updates clearly doesn't sound like a good idea to me. Could you tell me why it isn't a good idea? I though the overhead is the least, and we don't need to sync between bo and its

Re: [PATCH 00/13] shadow page table support

2016-08-03 Thread zhoucm1
On 2016年08月03日 21:39, Christian König wrote: Doubling all the page table updates clearly doesn't sound like a good idea to me. Could you tell me why it isn't a good idea? I though the overhead is the least, and we don't need to sync between bo and its shadow, aren't we? Regards, David Zhou

Re: [PATCH 00/13] shadow page table support

2016-08-03 Thread Christian König
Patch #1 looks like a fix to me, please add my rb and push ASAP. You should separate such fixes from bugger sets, send out individually and maybe ping Alex to review and add them to his fixes branch. Patch #2: + amdgpu_ttm_placement_init(adev, &placement, +

[PATCH 00/13] shadow page table support

2016-08-02 Thread Chunming Zhou
Since we cannot make sure VRAM is safe after gpu reset, page table backup is neccessary, shadow page table is sense way to recovery page talbe when gpu reset happens. We need to allocate GTT bo as the shadow of VRAM bo when creating page table, and make them same. After gpu reset, we will need to u

Re: [PATCH 00/13] shadow page table support

2016-08-01 Thread zhoucm1
ping... Don't know where Christian is. any others could review it? Thanks, David Zhou On 2016年07月28日 18:11, Chunming Zhou wrote: Since we cannot make sure VRAM is safe after gpu reset, page table backup is neccessary, shadow page table is sense way to recovery page talbe when gpu reset happens

[PATCH 00/13] shadow page table support

2016-07-28 Thread Chunming Zhou
Since we cannot make sure VRAM is safe after gpu reset, page table backup is neccessary, shadow page table is sense way to recovery page talbe when gpu reset happens. We need to allocate GTT bo as the shadow of VRAM bo when creating page table, and make them same. After gpu reset, we will need to u

Re: [PATCH 00/13] shadow page table support

2016-07-26 Thread zhoucm1
On 2016年07月26日 17:05, Christian König wrote: Am 26.07.2016 um 10:41 schrieb zhoucm1: On 2016年07月26日 16:27, Christian König wrote: Am 26.07.2016 um 07:33 schrieb zhoucm1: On 2016年07月26日 10:40, zhoucm1 wrote: 1. We add an optional "shadow" flag so that when a BO in VRAM is allocated we al

RE: [PATCH 00/13] shadow page table support

2016-07-26 Thread Liu, Monk
Correction, after full asic reset BR Monk -Original Message- From: Liu, Monk Sent: Tuesday, July 26, 2016 4:51 PM To: 'Chunming Zhou' ; amd-gfx@lists.freedesktop.org Cc: Zhou, David(ChunMing) Subject: RE: [PATCH 00/13] shadow page table support Hi David amdgpu_asic_reset wi

RE: [PATCH 00/13] shadow page table support

2016-07-26 Thread Liu, Monk
- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Chunming Zhou Sent: Monday, July 25, 2016 3:22 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou, David(ChunMing) Subject: [PATCH 00/13] shadow page table support Since we cannot make sure VRAM is safe after gpu reset, page

Re: [PATCH 00/13] shadow page table support

2016-07-26 Thread Christian König
Am 26.07.2016 um 10:41 schrieb zhoucm1: On 2016年07月26日 16:27, Christian König wrote: Am 26.07.2016 um 07:33 schrieb zhoucm1: On 2016年07月26日 10:40, zhoucm1 wrote: 1. We add an optional "shadow" flag so that when a BO in VRAM is allocated we also allocate a shadow BO in GART. 2. We have an

Re: [PATCH 00/13] shadow page table support

2016-07-26 Thread zhoucm1
On 2016年07月26日 16:27, Christian König wrote: Am 26.07.2016 um 07:33 schrieb zhoucm1: On 2016年07月26日 10:40, zhoucm1 wrote: 1. We add an optional "shadow" flag so that when a BO in VRAM is allocated we also allocate a shadow BO in GART. 2. We have another "backup" flag that says on the next

Re: [PATCH 00/13] shadow page table support

2016-07-26 Thread Christian König
Am 26.07.2016 um 07:33 schrieb zhoucm1: On 2016年07月26日 10:40, zhoucm1 wrote: 1. We add an optional "shadow" flag so that when a BO in VRAM is allocated we also allocate a shadow BO in GART. 2. We have another "backup" flag that says on the next command submission the BO is backed up from VR

Re: [PATCH 00/13] shadow page table support

2016-07-25 Thread zhoucm1
On 2016年07月26日 10:40, zhoucm1 wrote: 1. We add an optional "shadow" flag so that when a BO in VRAM is allocated we also allocate a shadow BO in GART. 2. We have another "backup" flag that says on the next command submission the BO is backed up from VRAM to GART before that submission. 3. W

Re: [PATCH 00/13] shadow page table support

2016-07-25 Thread zhoucm1
On 2016年07月25日 18:31, Christian König wrote: First of all patches #10 and #11 look like bug fixes to existing code to me. So we should fix those problems before working on anything else. Patch #10 is Reviewed-by: Christian König Patch #11: list_for_each_entry(s_job, &sched->ring_mirr

Re: [PATCH 00/13] shadow page table support

2016-07-25 Thread Christian König
First of all patches #10 and #11 look like bug fixes to existing code to me. So we should fix those problems before working on anything else. Patch #10 is Reviewed-by: Christian König Patch #11: list_for_each_entry(s_job, &sched->ring_mirror_list, node) { struct amd_sched_fence

[PATCH 00/13] shadow page table support

2016-07-25 Thread Chunming Zhou
Since we cannot make sure VRAM is safe after gpu reset, page table backup is neccessary, shadow page table is sense way to recovery page talbe when gpu reset happens. We need to allocate GTT bo as the shadow of VRAM bo when creating page table, and make them same. After gpu reset, we will need to u