Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 22:13 schrieb Felix Kuehling: Am 2021-01-14 um 11:51 a.m. schrieb Jerome Glisse: On Thu, Jan 14, 2021 at 02:37:36PM +0100, Christian König wrote: Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more about it but have not yet, anyway here

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Felix Kuehling
Am 2021-01-14 um 11:51 a.m. schrieb Jerome Glisse: > On Thu, Jan 14, 2021 at 02:37:36PM +0100, Christian König wrote: >> Am 14.01.21 um 12:52 schrieb Daniel Vetter: >>> [SNIP] > I had a new idea, i wanted to think more about it but have not yet, > anyway here it is. Adding a new callback t

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 08:08:06PM +0100, Christian König wrote: > Am 14.01.21 um 17:36 schrieb Daniel Vetter: > > On Thu, Jan 14, 2021 at 5:01 PM Christian König > > wrote: > > > Am 14.01.21 um 16:40 schrieb Daniel Vetter: > > > > [SNIP] > > > > > So I think we have to somehow solve this in the k

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 17:36 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 5:01 PM Christian König wrote: Am 14.01.21 um 16:40 schrieb Daniel Vetter: [SNIP] So I think we have to somehow solve this in the kernel or we will go in circles all the time. So from that pov I think the kernel should at m

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Jerome Glisse
On Thu, Jan 14, 2021 at 02:37:36PM +0100, Christian König wrote: > Am 14.01.21 um 12:52 schrieb Daniel Vetter: > > [SNIP] > > > > I had a new idea, i wanted to think more about it but have not yet, > > > > anyway here it is. Adding a new callback to dma fence which ask the > > > > question can it

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 5:01 PM Christian König wrote: > > Am 14.01.21 um 16:40 schrieb Daniel Vetter: > > [SNIP] > >> So I think we have to somehow solve this in the kernel or we will go in > >> circles all the time. > >> > >>> So from that pov I think the kernel should at most deal with an > >>>

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 16:40 schrieb Daniel Vetter: [SNIP] So I think we have to somehow solve this in the kernel or we will go in circles all the time. So from that pov I think the kernel should at most deal with an hmm_fence for cross-process communication and maybe some standard wait primitives (fo

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 4:08 PM Christian König wrote: > Am 14.01.21 um 15:23 schrieb Daniel Vetter: > > On Thu, Jan 14, 2021 at 3:13 PM Christian König > > wrote: > >> Am 14.01.21 um 14:57 schrieb Daniel Vetter: > >>> On Thu, Jan 14, 2021 at 2:37 PM Christian König > >>> wrote: > Am 14.01.

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 15:23 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 3:13 PM Christian König wrote: Am 14.01.21 um 14:57 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 2:37 PM Christian König wrote: Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 3:13 PM Christian König wrote: > > Am 14.01.21 um 14:57 schrieb Daniel Vetter: > > On Thu, Jan 14, 2021 at 2:37 PM Christian König > > wrote: > >> Am 14.01.21 um 12:52 schrieb Daniel Vetter: > >>> [SNIP] > > I had a new idea, i wanted to think more about it but have no

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 14:57 schrieb Daniel Vetter: On Thu, Jan 14, 2021 at 2:37 PM Christian König wrote: Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more about it but have not yet, anyway here it is. Adding a new callback to dma fence which ask the questio

Re: HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 2:37 PM Christian König wrote: > > Am 14.01.21 um 12:52 schrieb Daniel Vetter: > > [SNIP] > >>> I had a new idea, i wanted to think more about it but have not yet, > >>> anyway here it is. Adding a new callback to dma fence which ask the > >>> question can it dead lock ? An

HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD)

2021-01-14 Thread Christian König
Am 14.01.21 um 12:52 schrieb Daniel Vetter: [SNIP] I had a new idea, i wanted to think more about it but have not yet, anyway here it is. Adding a new callback to dma fence which ask the question can it dead lock ? Any time a GPU driver has pending page fault (ie something calling into the mm) i

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Christian König
Am 14.01.21 um 06:34 schrieb Felix Kuehling: Am 2021-01-11 um 11:29 a.m. schrieb Daniel Vetter: On Fri, Jan 08, 2021 at 12:56:24PM -0500, Felix Kuehling wrote: Am 2021-01-08 um 11:53 a.m. schrieb Daniel Vetter: On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling wrote: Am 2021-01-08 um 11:06 a.m.

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 11:49 AM Christian König wrote: > > Am 13.01.21 um 17:56 schrieb Jerome Glisse: > > On Fri, Jan 08, 2021 at 03:40:07PM +0100, Daniel Vetter wrote: > >> On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: > >>> Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: >

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Christian König
Am 13.01.21 um 17:56 schrieb Jerome Glisse: On Fri, Jan 08, 2021 at 03:40:07PM +0100, Daniel Vetter wrote: On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: This is

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 10:26 AM Daniel Vetter wrote: > > On Thu, Jan 14, 2021 at 4:27 AM Jerome Glisse wrote: > > > > On Wed, Jan 13, 2021 at 09:31:11PM +0100, Daniel Vetter wrote: > > > On Wed, Jan 13, 2021 at 5:56 PM Jerome Glisse wrote: > > > > On Fri, Jan 08, 2021 at 03:40:07PM +0100, Danie

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-14 Thread Daniel Vetter
On Thu, Jan 14, 2021 at 4:27 AM Jerome Glisse wrote: > > On Wed, Jan 13, 2021 at 09:31:11PM +0100, Daniel Vetter wrote: > > On Wed, Jan 13, 2021 at 5:56 PM Jerome Glisse wrote: > > > On Fri, Jan 08, 2021 at 03:40:07PM +0100, Daniel Vetter wrote: > > > > On Thu, Jan 07, 2021 at 11:25:41AM -0500, F

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-13 Thread Felix Kuehling
Am 2021-01-11 um 11:29 a.m. schrieb Daniel Vetter: > On Fri, Jan 08, 2021 at 12:56:24PM -0500, Felix Kuehling wrote: >> Am 2021-01-08 um 11:53 a.m. schrieb Daniel Vetter: >>> On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling >>> wrote: Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter: > On

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-13 Thread Jerome Glisse
On Wed, Jan 13, 2021 at 09:31:11PM +0100, Daniel Vetter wrote: > On Wed, Jan 13, 2021 at 5:56 PM Jerome Glisse wrote: > > On Fri, Jan 08, 2021 at 03:40:07PM +0100, Daniel Vetter wrote: > > > On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: > > > > Am 2021-01-07 um 4:23 a.m. schrieb

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-13 Thread Felix Kuehling
Am 2021-01-13 um 11:47 a.m. schrieb Jerome Glisse: > On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: >> This is the first version of our HMM based shared virtual memory manager >> for KFD. There are still a number of known issues that we're working through >> (see below). This will

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-13 Thread Daniel Vetter
On Wed, Jan 13, 2021 at 5:56 PM Jerome Glisse wrote: > On Fri, Jan 08, 2021 at 03:40:07PM +0100, Daniel Vetter wrote: > > On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: > > > Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: > > > > On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-13 Thread Jerome Glisse
On Fri, Jan 08, 2021 at 03:40:07PM +0100, Daniel Vetter wrote: > On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: > > Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: > > > On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: > > >> This is the first version of our HMM ba

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-13 Thread Jerome Glisse
On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: > This is the first version of our HMM based shared virtual memory manager > for KFD. There are still a number of known issues that we're working through > (see below). This will likely lead to some pretty significant changes in > MMU

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-11 Thread Daniel Vetter
On Fri, Jan 08, 2021 at 12:56:24PM -0500, Felix Kuehling wrote: > > Am 2021-01-08 um 11:53 a.m. schrieb Daniel Vetter: > > On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling > > wrote: > >> > >> Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter: > >>> On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling >

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Felix Kuehling
Am 2021-01-08 um 11:53 a.m. schrieb Daniel Vetter: > On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling wrote: >> >> Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter: >>> On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling >>> wrote: Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: > On Thu, Ja

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Daniel Vetter
On Fri, Jan 8, 2021 at 5:36 PM Felix Kuehling wrote: > > > Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter: > > On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling > > wrote: > >> Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: > >>> On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote:

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Felix Kuehling
Am 2021-01-08 um 11:06 a.m. schrieb Daniel Vetter: > On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling wrote: >> Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: >>> On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: > On Wed, J

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Daniel Vetter
On Fri, Jan 8, 2021 at 4:58 PM Felix Kuehling wrote: > > Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: > > On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: > >> Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: > >>> On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Felix Kuehling
Am 2021-01-08 um 9:40 a.m. schrieb Daniel Vetter: > On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: >> Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: >>> On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: This is the first version of our HMM based shared virtual

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Christian König
Am 08.01.21 um 15:40 schrieb Daniel Vetter: On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: This is the first version of our HMM based shared virtual memory manager

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-08 Thread Daniel Vetter
On Thu, Jan 07, 2021 at 11:25:41AM -0500, Felix Kuehling wrote: > Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: > > On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: > >> This is the first version of our HMM based shared virtual memory manager > >> for KFD. There are still a numbe

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-07 Thread Felix Kuehling
Am 2021-01-07 um 4:23 a.m. schrieb Daniel Vetter: > On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: >> This is the first version of our HMM based shared virtual memory manager >> for KFD. There are still a number of known issues that we're working through >> (see below). This will l

Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-07 Thread Daniel Vetter
On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote: > This is the first version of our HMM based shared virtual memory manager > for KFD. There are still a number of known issues that we're working through > (see below). This will likely lead to some pretty significant changes in > MMU

[PATCH 00/35] Add HMM-based SVM memory manager to KFD

2021-01-06 Thread Felix Kuehling
This is the first version of our HMM based shared virtual memory manager for KFD. There are still a number of known issues that we're working through (see below). This will likely lead to some pretty significant changes in MMU notifier handling and locking on the migration code paths. So don't get