On 2/17/2022 8:05 AM, Quan, Evan wrote:
[AMD Official Use Only]
-Original Message-
From: Lazar, Lijo
Sent: Friday, February 11, 2022 9:40 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ;
rui.hu...@amd.com
Subject: Re: [PATCH 05/12] drm/amd/pm: move the
[AMD Official Use Only]
> -Original Message-
> From: Lazar, Lijo
> Sent: Friday, February 11, 2022 9:40 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ;
> rui.hu...@amd.com
> Subject: Re: [PATCH 05/12] drm/amd/pm: move the check for dpm
> enablement to
[Public]
> -Original Message-
> From: Chen, Guchun
> Sent: Friday, February 11, 2022 4:07 PM
> To: Quan, Evan ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; Lazar, Lijo
> ; Quan, Evan ; Huang, Ray
>
> Subject: RE: [PATCH 05/12] drm/amd/pm: move the check for dpm
>
On 2/11/2022 1:22 PM, Evan Quan wrote:
Instead of checking this in every instance(framework), moving that check to
amdgpu_dpm.c is more proper. And that can make code clean and tidy.
Signed-off-by: Evan Quan
Change-Id: I2f83a3b860e8aa12cc86f119011f520fbe21a301
---
[Public]
mutex_lock(>pm.mutex);
- ret = smu_write_watermarks_table(smu);
+ ret =
pp_funcs->set_watermarks_for_clock_ranges(adev->powerplay.pp_handle,
+ NULL);
mutex_unlock(>pm.mutex);
I guess we should separate this from
Instead of checking this in every instance(framework), moving that check to
amdgpu_dpm.c is more proper. And that can make code clean and tidy.
Signed-off-by: Evan Quan
Change-Id: I2f83a3b860e8aa12cc86f119011f520fbe21a301
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 5 +-