RE: [PATCH 09/11] drm/amdkfd: Fix kernel-queue wrapping bugs

2017-09-18 Thread Russell, Kent
, Felix; Oded Gabbay Cc: Zhao, Yong; amd-gfx list Subject: RE: [PATCH 09/11] drm/amdkfd: Fix kernel-queue wrapping bugs Correct (coming from the guy who did all of the checkpatch cleanup for KFD). For multi-line comments, /* Can be on its own, or on the same line as the comment. */ has

RE: [PATCH 09/11] drm/amdkfd: Fix kernel-queue wrapping bugs

2017-09-18 Thread Russell, Kent
- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Felix Kuehling Sent: Monday, September 18, 2017 11:22 AM To: Oded Gabbay Cc: Zhao, Yong; amd-gfx list Subject: Re: [PATCH 09/11] drm/amdkfd: Fix kernel-queue wrapping bugs On 2017-09-17 08:03 AM, Oded Gabbay wrote: > On

Re: [PATCH 09/11] drm/amdkfd: Fix kernel-queue wrapping bugs

2017-09-18 Thread Felix Kuehling
On 2017-09-17 08:03 AM, Oded Gabbay wrote: > On Sat, Sep 16, 2017 at 2:43 AM, Felix Kuehling > wrote: >> From: Yong Zhao >> >> Avoid intermediate negative numbers when doing calculations with a mix >> of signed and unsigned variables where implicit

Re: [PATCH 09/11] drm/amdkfd: Fix kernel-queue wrapping bugs

2017-09-18 Thread Felix Kuehling
On 2017-09-17 08:03 AM, Oded Gabbay wrote: > On Sat, Sep 16, 2017 at 2:43 AM, Felix Kuehling > wrote: >> From: Yong Zhao >> >> Avoid intermediate negative numbers when doing calculations with a mix >> of signed and unsigned variables where implicit

Re: [PATCH 09/11] drm/amdkfd: Fix kernel-queue wrapping bugs

2017-09-17 Thread Oded Gabbay
On Sat, Sep 16, 2017 at 2:43 AM, Felix Kuehling wrote: > From: Yong Zhao > > Avoid intermediate negative numbers when doing calculations with a mix > of signed and unsigned variables where implicit conversions can lead > to unexpected results. > > When