Am 20.02.19 um 09:10 schrieb zhoucm1:
On 2019年02月20日 15:59, Koenig, Christian wrote:
Am 20.02.19 um 05:53 schrieb zhoucm1:
On 2019年02月19日 19:32, Koenig, Christian wrote:
Hi David,
Could you have a look if it's reasonable?
Patch #1 is also something I already fixed on my local branch.
But pat
On 2019年02月20日 15:59, Koenig, Christian wrote:
Am 20.02.19 um 05:53 schrieb zhoucm1:
On 2019年02月19日 19:32, Koenig, Christian wrote:
Hi David,
Could you have a look if it's reasonable?
Patch #1 is also something I already fixed on my local branch.
But patch #2 won't work like this.
We
Am 20.02.19 um 05:53 schrieb zhoucm1:
On 2019年02月19日 19:32, Koenig, Christian wrote:
Hi David,
Could you have a look if it's reasonable?
Patch #1 is also something I already fixed on my local branch.
But patch #2 won't work like this.
We can't return an error from drm_syncobj_add_point() beca
On 2019年02月19日 19:32, Koenig, Christian wrote:
Hi David,
Could you have a look if it's reasonable?
Patch #1 is also something I already fixed on my local branch.
But patch #2 won't work like this.
We can't return an error from drm_syncobj_add_point() because we
already submitted work to
Hi David,
Could you have a look if it's reasonable?
Patch #1 is also something I already fixed on my local branch.
But patch #2 won't work like this.
We can't return an error from drm_syncobj_add_point() because we already
submitted work to the hardware. And just dropping the fence like you do
Thanks David,
Will give this a go!
-Lionel
On 19/02/2019 10:46, zhoucm1 wrote:
Hi Lionel,
the attached should fix your problem and also messed signal order.
Hi Christian,
Could you have a look if it's reasonable?
btw: I pushed to change to
https://github.com/amingriyue/timeline-syncobj-
Hi Lionel,
the attached should fix your problem and also messed signal order.
Hi Christian,
Could you have a look if it's reasonable?
btw: I pushed to change to
https://github.com/amingriyue/timeline-syncobj-kernel, which is already
rebased to latest drm-misc(kernel 5.0). You can directly u
Am 18.02.19 um 13:07 schrieb Lionel Landwerlin:
Thanks guys :)
You mentioned that signaling out of order is illegal.
Is this illegal with regard to the vulkan spec or to the syncobj implementation?
David is the expert on that, but as far as I know that is forbidden by the
vulkan spec.
I'm not f
Thanks guys :)
You mentioned that signaling out of order is illegal.
Is this illegal with regard to the vulkan spec or to the syncobj
implementation?
I'm not finding anything in the vulkan spec that makes out of order
signaling illegal.
That's why I came up with this test, just verifying that
Hi David,
well I think Lionel is testing the invalid signal order on purpose :)
Anyway we really need to handle invalid order graceful here. E.g. either the
same way as during CS or we abort and return an error message.
I think just using the same approach as during CS ist the best we can do.
Hi Lionel,
I checked your igt test case,
uint64_t points[5] = { 1, 5, 3, 7, 6 };
which is illegal signal order.
I must admit we should handle it gracefully if signal isn't in-order,
and we shouldn't lead to deadlock.
Hi Christian,
Can we just ignore when signal point X <= timeline Y? Or ju
Hi David,
Thanks a lot for point me to the tests you've added in IGT.
While adding a test with that signals fences imported into a timeline
syncobj out of order, I ran into a deadlock.
Here is the test :
https://github.com/djdeath/intel-gpu-tools/commit/1e46cf7e7bff09b78a24367ddc2314f97eb0a1b9
I would rather just use a single IOCTL for this and handle point 0 as
distinction if we should add a new point or replace the binary one.
Christian.
Am 07.12.18 um 10:55 schrieb Chunming Zhou:
> we need to import/export timeline point
>
> Signed-off-by: Chunming Zhou
> ---
> drivers/gpu/drm/d
we need to import/export timeline point
Signed-off-by: Chunming Zhou
---
drivers/gpu/drm/drm_internal.h | 4 +++
drivers/gpu/drm/drm_ioctl.c| 6
drivers/gpu/drm/drm_syncobj.c | 66 ++
include/uapi/drm/drm.h | 10 ++
4 files changed, 86 inse
14 matches
Mail list logo
