Re: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-09-17 Thread Zhang, Jerry (Junwei)
muel <samuel...@amd.com> Subject: [PATCH 1/1] amdgpu: move asic id table to a separate file From: Xiaojie Yuan <xiaojie.y...@amd.com> Change-Id: I12216da14910f5e2b0970bc1fafc2a20b0ef1ba9 Signed-off-by: Samuel Li <samuel...@amd.com> --- amdgpu/Makefile.am | 2 + amdgpu/Makef

Re: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-24 Thread Michel Dänzer
On 25/05/17 12:10 AM, Li, Samuel wrote: >> There's no need for a separate repo upstream. It's purely to aid >> internal packaging. > As a first step, we can put a snapshot in libdrm for now. External > packaging will face the same issue though ... the packagers need to > put the ids in various

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-24 Thread Li, Samuel
Xiaojie <xiaojie.y...@amd.com> Subject: RE: [PATCH 1/1] amdgpu: move asic id table to a separate file > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Thursday, May 11, 2017 8:50 PM > To: Li, Samuel &g

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-23 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Michel Dänzer > Sent: Thursday, May 11, 2017 8:50 PM > To: Li, Samuel > Cc: amd-gfx@lists.freedesktop.org; Yuan, Xiaojie > Subject: Re: [PATCH 1/1] amdgpu: move asic i

Re: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-14 Thread Michel Dänzer
On 13/05/17 12:21 AM, Li, Samuel wrote: > My understanding is this is actually a data file. Similar to amdgpu > firmware, which is also separate from the kernel source code. I don't think the reasons for the linux-firmware repository being separate from linux apply to this file. Please provide

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-12 Thread Li, Samuel
md-gfx@lists.freedesktop.org; Yuan, Xiaojie <xiaojie.y...@amd.com> Subject: Re: [PATCH 1/1] amdgpu: move asic id table to a separate file On 12/05/17 06:13 AM, Li, Samuel wrote: > Submitted a request to create a new repo on freedesktop. What's the point of having a separate repository ups

Re: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-11 Thread Michel Dänzer
On 12/05/17 06:13 AM, Li, Samuel wrote: > Submitted a request to create a new repo on freedesktop. What's the point of having a separate repository upstream? Can't we just keep it in the libdrm repository? -- Earthling Michel Dänzer | http://www.amd.com Libre

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-11 Thread Li, Samuel
> Subject: RE: [PATCH 1/1] amdgpu: move asic id table to a separate file Submitted a request to create a new repo on freedesktop. Michel, do you have the privilege to create it? https://bugs.freedesktop.org/show_bug.cgi?id=99589 Sam -Original Message- From: Michel Dänzer [mailto:mic...

Re: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-11 Thread Yuan, Xiaojie
@lists.freedesktop.org Cc: Yuan, Xiaojie; Li, Samuel Subject: [PATCH 1/1] amdgpu: move asic id table to a separate file From: Xiaojie Yuan <xiaojie.y...@amd.com> Change-Id: I12216da14910f5e2b0970bc1fafc2a20b0ef1ba9 Signed-off-by: Samuel Li <samuel...@amd.com> --- amdgpu/Makefile.am

RE: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-11 Thread Li, Samuel
Good catch! Sam From: Yuan, Xiaojie Sent: Thursday, May 11, 2017 6:51 AM To: Li, Samuel <samuel...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/1] amdgpu: move asic id table to a separate file Hi Samuel, Here's an off-by-one error: +

Re: [PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-10 Thread Michel Dänzer
On 11/05/17 06:10 AM, Li, Samuel wrote: > Also attach a sample ids file for reference. The names are from marketing, not > related to source code and no reviews necessary here:) Just because it's not source code doesn't mean no review is necessary. :) > It can be put in directory

[PATCH 1/1] amdgpu: move asic id table to a separate file

2017-05-10 Thread Samuel Li
From: Xiaojie Yuan Change-Id: I12216da14910f5e2b0970bc1fafc2a20b0ef1ba9 Signed-off-by: Samuel Li --- amdgpu/Makefile.am | 2 + amdgpu/Makefile.sources | 2 +- amdgpu/amdgpu_asic_id.c | 198 +++