Re: [PATCH 1/1] drm/virtio: Implement device_attach

2024-01-11 Thread Christian König
Am 11.01.24 um 09:52 schrieb Zhang, Julia: On 2024/1/10 18:21, Daniel Vetter wrote: On Wed, Jan 10, 2024 at 05:56:28PM +0800, Julia Zhang wrote: drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be implemented, or else return ENOSYS. Virtio has no get_sg_table implemented for

Re: [PATCH 1/1] drm/virtio: Implement device_attach

2024-01-11 Thread Zhang, Julia
On 2024/1/10 18:21, Daniel Vetter wrote: > On Wed, Jan 10, 2024 at 05:56:28PM +0800, Julia Zhang wrote: >> drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be >> implemented, or else return ENOSYS. Virtio has no get_sg_table >> implemented for vram object. To fix this, add a

Re: [PATCH 1/1] drm/virtio: Implement device_attach

2024-01-10 Thread Daniel Vetter
On Wed, Jan 10, 2024 at 11:46:35AM +0100, Christian König wrote: > Am 10.01.24 um 11:22 schrieb Daniel Vetter: > > On Wed, Jan 10, 2024 at 11:19:37AM +0100, Christian König wrote: > > > Am 10.01.24 um 10:56 schrieb Julia Zhang: > > > > drm_gem_map_attach() requires

Re: [PATCH 1/1] drm/virtio: Implement device_attach

2024-01-10 Thread Christian König
Am 10.01.24 um 11:22 schrieb Daniel Vetter: On Wed, Jan 10, 2024 at 11:19:37AM +0100, Christian König wrote: Am 10.01.24 um 10:56 schrieb Julia Zhang: drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be implemented, or else return ENOSYS. Virtio has no get_sg_table

Re: [PATCH 1/1] drm/virtio: Implement device_attach

2024-01-10 Thread Daniel Vetter
On Wed, Jan 10, 2024 at 11:19:37AM +0100, Christian König wrote: > Am 10.01.24 um 10:56 schrieb Julia Zhang: > > drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be > > implemented, or else return ENOSYS. Virtio has no get_sg_table > > implemented for vram object. To fix this,

Re: [PATCH 1/1] drm/virtio: Implement device_attach

2024-01-10 Thread Daniel Vetter
On Wed, Jan 10, 2024 at 05:56:28PM +0800, Julia Zhang wrote: > drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be > implemented, or else return ENOSYS. Virtio has no get_sg_table > implemented for vram object. To fix this, add a new device_attach to > call drm_gem_map_attach()

Re: [PATCH 1/1] drm/virtio: Implement device_attach

2024-01-10 Thread Christian König
Am 10.01.24 um 10:56 schrieb Julia Zhang: drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be implemented, or else return ENOSYS. Virtio has no get_sg_table implemented for vram object. To fix this, add a new device_attach to call drm_gem_map_attach() for shmem object and

[PATCH 1/1] drm/virtio: Implement device_attach

2024-01-10 Thread Julia Zhang
drm_gem_map_attach() requires drm_gem_object_funcs.get_sg_table to be implemented, or else return ENOSYS. Virtio has no get_sg_table implemented for vram object. To fix this, add a new device_attach to call drm_gem_map_attach() for shmem object and return 0 for vram object instead of calling