[PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures

2021-02-21 Thread Evan Quan
To make sure they are naturally aligned. Change-Id: I496a5b79158bdbd2e17f179098939e050b2ad489 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/include/kgd_pp_interface.h| 11 ++- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h| 4 ++-- drivers/gpu/drm/amd/pm/powerplay/hwm

Re: [PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures

2021-02-22 Thread Alex Deucher
On Sun, Feb 21, 2021 at 11:03 PM Evan Quan wrote: > > To make sure they are naturally aligned. > > Change-Id: I496a5b79158bdbd2e17f179098939e050b2ad489 > Signed-off-by: Evan Quan Won't this break existing apps that query this info? We need to make sure umr and rocm-smi can handle this. Alex

Re: [PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures

2021-02-23 Thread Tom St Denis
This is why I advocated for the sysfs output to be either standard packed or serialized. It was a hack as it is anyways. On Mon, Feb 22, 2021 at 4:46 PM Alex Deucher wrote: > On Sun, Feb 21, 2021 at 11:03 PM Evan Quan wrote: > > > > To make sure they are naturally aligned. > > > > Change-Id: I

[PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures V2

2021-02-28 Thread Evan Quan
To make sure they are naturally aligned. Also updating the data type for link_speed/width for future PCIE5 support. Change-Id: I0a139e1e1f09fe27deffdce1cec6ea4594947625 Signed-off-by: Evan Quan --- .../gpu/drm/amd/include/kgd_pp_interface.h| 114 ++ 1 file changed, 114 insert

[PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures V3

2021-03-01 Thread Evan Quan
To make sure they are naturally aligned. Also updating the data type for link_speed/width for future PCIE5 support. V2: define new structures with minor version bumped V3: update data type of energy_accumulator as 64bit and drop unnecessary padding members Change-Id: I0a139e1e1f09fe27deffdce1

RE: [PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures V2

2021-02-28 Thread Lazar, Lijo
[AMD Public Use] -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Monday, March 1, 2021 11:20 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures V2 To make sure they are

RE: [PATCH 1/2] drm/amd/pm: correct gpu metrics related data structures V2

2021-03-01 Thread Quan, Evan
gpu metrics related data structures V2 [AMD Public Use] -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Monday, March 1, 2021 11:20 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH 1/2] drm/amd/pm: correct gpu metrics related