Re: [PATCH 1/2] drm/amdgpu/powerplay: Refactor SMU message handling for safety

2020-02-26 Thread Deucher, Alexander
/powerplay: Refactor SMU message handling for safety Hey Alex, The reason I didn't transition the other code is that I have no hardware to test with. I'll go ahead and do it, but someone with the hardware should at least ensure it boots properly (vega20, and something on smu_v12_0). With that, I'm

Re: [PATCH 1/2] drm/amdgpu/powerplay: Refactor SMU message handling for safety

2020-02-25 Thread Matt Coffin
Hey Alex, The reason I didn't transition the other code is that I have no hardware to test with. I'll go ahead and do it, but someone with the hardware should at least ensure it boots properly (vega20, and something on smu_v12_0). With that, I'm good with doing it, I just don't want to risk

Re: [PATCH 1/2] drm/amdgpu/powerplay: Refactor SMU message handling for safety

2020-02-25 Thread Alex Deucher
On Wed, Feb 19, 2020 at 2:19 PM Matt Coffin wrote: > > Move the responsibility for reading argument registers into the > smu_send_smc_msg* implementations, so that adding a message-sending lock > to protect the SMU registers will result in the lock still being held > when the argument is read. >

[PATCH 1/2] drm/amdgpu/powerplay: Refactor SMU message handling for safety

2020-02-19 Thread Matt Coffin
Move the responsibility for reading argument registers into the smu_send_smc_msg* implementations, so that adding a message-sending lock to protect the SMU registers will result in the lock still being held when the argument is read. For code compatibility on hardware I don't have the funds to