I thought I reviewed this one together with another one from you that fixed
hive refcount leak. You sent them in series.
Anyway, go ahead to submit with my RB.
Thanks.
Regards,
Hawking
From: amd-gfx on behalf of Chai, Thomas
Date: Thursday, August 25, 2022 at 00:37
To:
[AMD Official Use Only - General]
Ping on this series.
-Original Message-
From: Chai, Thomas
Sent: Friday, August 12, 2022 5:13 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chai, Thomas ; Zhang, Hawking ;
Wang, Yang(Kevin) ; Chai, Thomas
Subject: [PATCH 1/2] drm/amdgpu: The call to
[AMD Official Use Only - General]
OK, I will update the patch.
From: Zhang, Hawking
Sent: Tuesday, August 16, 2022 11:51 AM
To: Chai, Thomas ; amd-gfx@lists.freedesktop.org
Cc: Wang, Yang(Kevin)
Subject: Re: [PATCH 1/2] drm/amdgpu: The call to amdgpu_xgmi_remove_device
needs to be earlier
Fixed typo
Regards,
Hawking
From: Zhang, Hawking
Date: Tuesday, August 16, 2022 at 11:49
To: Chai, Thomas , amd-gfx@lists.freedesktop.org
Cc: Wang, Yang(Kevin)
Subject: RE: [PATCH 1/2] drm/amdgpu: The call to amdgpu_xgmi_remove_device
needs to be earlier than psp_hw_fini
[AMD Official Use
[AMD Official Use Only - General]
Alternatively, we might be better split xgmi ta terminate from
xgmi_remove_device. In psp_hw_fini, check ta->fw and num_of_physical_mode to
terminate xgmi ta. and make amdgpu_xgmi_remove_device only deal with software
fini, like add_device.
Regards,
Hawking
The amdgpu_xgmi_remove_device function will send unload command
to psp through psp ring to terminate xgmi, but psp ring has been
destroyed in psp_hw_fini.
Signed-off-by: YiPeng Chai
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
