Re: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-29 Thread Luben Tuikov
Reviewed-by: Luben Tuikov On 2020-07-29 04:23, Liu ChengZhe wrote: > 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; > 2. Check pointer before release firmware. > > v2: use CHIP_SIENNA_CICHLID instead > v3: remove local "bool ret"; fix grammer issue > v4: use my name instead of

[PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-29 Thread Liu ChengZhe
1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; 2. Check pointer before release firmware. v2: use CHIP_SIENNA_CICHLID instead v3: remove local "bool ret"; fix grammer issue v4: use my name instead of "root" v5: fix grammer issue and indent issue Signed-off-by: Liu ChengZhe ---

Re: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-28 Thread Luben Tuikov
On 2020-07-28 1:36 a.m., Liu ChengZhe wrote: > 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; > 2. Check pointer before release firmware. > > v2: use CHIP_SIENNA_CICHLID instead > v3: remove local "bool ret"; fix grammer issue > v4: use my name instead of "root"

Re: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-28 Thread Luben Tuikov
Thanks for this patch. On 2020-07-28 1:12 a.m., Liu ChengZhe wrote: > From: root You should fix your Git setup to show proper user name, not "root". I've prepared a Confluence page which shows a way to do it, and a few other things along the way:

[PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-27 Thread Liu ChengZhe
1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; 2. Check pointer before release firmware. v2: use CHIP_SIENNA_CICHLID instead v3: remove local "bool ret"; fix grammer issue v4: use my name instead of "root" Signed-off-by: Liu ChengZhe ---

[PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-27 Thread Liu ChengZhe
From: root 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; 2. Check pointer before release firmware. v2: use CHIP_SIENNA_CICHLID instead v3: remove local "bool ret"; fix grammer issue Signed-off-by: root --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 35

Re: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-27 Thread Luben Tuikov
On 2020-07-27 6:57 a.m., Liu ChengZhe wrote: > From: root > > 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; > 2. Check pointer before release firmware. > > Signed-off-by: root > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 40 + > 1 file

Re: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-27 Thread Deucher, Alexander
n ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ; Zhang, Hawking ; Xu, Feifei ; Wang, Kevin(Yang) ; Yuan, Xiaojie ; Liu, Cheng Zhe Subject: [PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV From: root 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; 2. Check pointer befo

[PATCH 1/2] drm amdgpu: Skip tmr load for SRIOV

2020-07-27 Thread Liu ChengZhe
From: root 1. For Navi12, CHIP_SIENNA_CICHLID, skip tmr load operation; 2. Check pointer before release firmware. Signed-off-by: root --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 40 + 1 file changed, 34 insertions(+), 6 deletions(-) diff --git