[PATCH 1/3] Revert "drm/amd/powerply: fix power reading on Fiji"

2018-04-04 Thread Rex Zhu
we don't have limit of [50ms, 4sec] sampling period. only confused the average power and max power. so don't need to increase delay time. This reverts commit 462d8dcc9fec0d89f1ff6a1f93f1d4f670878c71. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 3 +-- 1 file cha

[PATCH 1/3] Revert "drm/amd/powerply: fix power reading on Fiji"

2018-04-10 Thread Rex Zhu
we don't have limit of [50ms, 4sec] sampling period. smu calculate average gpu power in real time. we can read average gpu power through smu message or read special register. This reverts commit 462d8dcc9fec0d89f1ff6a1f93f1d4f670878c71. Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/h

Re: [PATCH 1/3] Revert "drm/amd/powerply: fix power reading on Fiji"

2018-04-04 Thread Eric Huang
Did you contact tools team about this? Since the smc messages PPSMC_MSG_PmStatusLogStart and PPSMC_MSG_PmStatusLogSample are exclusively used by tools, driver just shared it. And AGT gets different result as driver if you change it back to 20ms. To keep consistent result as AGT, please verify i

Re: [PATCH 1/3] Revert "drm/amd/powerply: fix power reading on Fiji"

2018-04-11 Thread Alex Deucher
On Wed, Apr 11, 2018 at 2:31 AM, Rex Zhu wrote: > we don't have limit of [50ms, 4sec] sampling period. > smu calculate average gpu power in real time. > we can read average gpu power through smu message or > read special register. > > This reverts commit 462d8dcc9fec0d89f1ff6a1f93f1d4f670878c71. >

Re: [PATCH 1/3] Revert "drm/amd/powerply: fix power reading on Fiji"

2018-04-11 Thread Eric Huang
If it is verified by SMU team, I am OK with it. Regards, Eric On 2018-04-11 01:19 PM, Alex Deucher wrote: On Wed, Apr 11, 2018 at 2:31 AM, Rex Zhu wrote: we don't have limit of [50ms, 4sec] sampling period. smu calculate average gpu power in real time. we can read average gpu power through sm