Re: [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling

2017-05-31 Thread Xie, AlexBin
May 31, 2017 9:07 AM To: Xie, AlexBin; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling I don't have strong opinion about where the code should be. But if we put this code in VM, there will be one extra array index operation because

Re: [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling

2017-05-31 Thread Xie, AlexBin
, 2017 2:57 AM To: Xie, AlexBin; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling Am 30.05.2017 um 23:47 schrieb Alex Xie: >Move several if statements and a loop statment from >run time to initialization time.

Re: [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling

2017-05-31 Thread Christian König
:* Xie, AlexBin; amd-gfx@lists.freedesktop.org *Subject:* Re: [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling Am 30.05.2017 um 23:47 schrieb Alex Xie: >Move several if statements and a loop statment from >run time to initialization time. Yeah, that's exactly what I'

Re: [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling

2017-05-31 Thread Christian König
Am 30.05.2017 um 23:47 schrieb Alex Xie: Move several if statements and a loop statment from run time to initialization time. Yeah, that's exactly what I've suggested before as well. Just keep the code inside amdgpu_vm.c (and the variable inside amdgpu_vm_manager), since this isn't

Re: [PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling

2017-05-30 Thread zhoucm1
On 2017年05月31日 05:47, Alex Xie wrote: Move several if statements and a loop statment from run time to initialization time. Signed-off-by: Alex Xie nice, Reviewed-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 33

[PATCH 1/3] drm/amdgpu: Optimize a function called by every IB sheduling

2017-05-30 Thread Alex Xie
Move several if statements and a loop statment from run time to initialization time. Signed-off-by: Alex Xie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 33 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 6 ++