[PATCH 1/3] drm/amdgpu: do not pass ttm_resource_manager to gtt_mgr

2021-10-19 Thread Nirmoy Das
Do not allow exported amdgpu_gtt_mgr_*() to accept any ttm_resource_manager pointer. Also there is no need to force other module to call a ttm function just to eventually call gtt_mgr functions. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +-- drivers/gpu/drm/a

Re: [PATCH 1/3] drm/amdgpu: do not pass ttm_resource_manager to gtt_mgr

2021-10-19 Thread Christian König
Am 19.10.21 um 20:14 schrieb Nirmoy Das: Do not allow exported amdgpu_gtt_mgr_*() to accept any ttm_resource_manager pointer. Also there is no need to force other module to call a ttm function just to eventually call gtt_mgr functions. That's a rather bad idea I think. The GTT and VRAM manager

Re: [PATCH 1/3] drm/amdgpu: do not pass ttm_resource_manager to gtt_mgr

2021-10-20 Thread Das, Nirmoy
On 10/20/2021 8:49 AM, Christian König wrote: Am 19.10.21 um 20:14 schrieb Nirmoy Das: Do not allow exported amdgpu_gtt_mgr_*() to accept any ttm_resource_manager pointer. Also there is no need to force other module to call a ttm function just to eventually call gtt_mgr functions. That's a r

Re: [PATCH 1/3] drm/amdgpu: do not pass ttm_resource_manager to gtt_mgr

2021-10-20 Thread Lazar, Lijo
On 10/20/2021 2:18 PM, Das, Nirmoy wrote: On 10/20/2021 8:49 AM, Christian König wrote: Am 19.10.21 um 20:14 schrieb Nirmoy Das: Do not allow exported amdgpu_gtt_mgr_*() to accept any ttm_resource_manager pointer. Also there is no need to force other module to call a ttm function just to ev

Re: [PATCH 1/3] drm/amdgpu: do not pass ttm_resource_manager to gtt_mgr

2021-10-20 Thread Christian König
Am 20.10.21 um 11:19 schrieb Lazar, Lijo: On 10/20/2021 2:18 PM, Das, Nirmoy wrote: On 10/20/2021 8:49 AM, Christian König wrote: Am 19.10.21 um 20:14 schrieb Nirmoy Das: Do not allow exported amdgpu_gtt_mgr_*() to accept any ttm_resource_manager pointer. Also there is no need to force othe

Re: [PATCH 1/3] drm/amdgpu: do not pass ttm_resource_manager to gtt_mgr

2021-10-20 Thread Das, Nirmoy
On 10/20/2021 12:49 PM, Christian König wrote: Am 20.10.21 um 11:19 schrieb Lazar, Lijo: On 10/20/2021 2:18 PM, Das, Nirmoy wrote: On 10/20/2021 8:49 AM, Christian König wrote: Am 19.10.21 um 20:14 schrieb Nirmoy Das: Do not allow exported amdgpu_gtt_mgr_*() to accept any ttm_resource_ma