Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-07-19 Thread Christian König
Am 19.07.19 um 00:34 schrieb Kuehling, Felix: On 2019-07-18 4:47 a.m., Christian König wrote: [SNIP] There is also a more general issue with direct submission that I found while you were on vacation. There is no locking of the ring buffer. So direct and non-direct submission to the same ring is

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-07-18 Thread Kuehling, Felix
On 2019-07-18 4:47 a.m., Christian König wrote: [snip] >>> This is a corner case we can handle later on. As long as the VM is >>> still alive just allocating page tables again should be sufficient for >>> this. >> Do you mean, instead of migrating page tables back, throwing them away >> and

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-07-18 Thread Christian König
Am 17.07.19 um 22:31 schrieb Kuehling, Felix: On 2019-07-17 5:10, Christian König wrote: Am 16.07.19 um 18:40 schrieb Kuehling, Felix: On 2019-07-16 9:36 a.m., Christian König wrote: Am 02.07.19 um 21:35 schrieb Kuehling, Felix: This assumes that page tables are resident when a page fault is

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-07-17 Thread Kuehling, Felix
On 2019-07-17 5:10, Christian König wrote: > Am 16.07.19 um 18:40 schrieb Kuehling, Felix: >> On 2019-07-16 9:36 a.m., Christian König wrote: >>> Am 02.07.19 um 21:35 schrieb Kuehling, Felix: This assumes that page tables are resident when a page fault is handled. >>> Yeah, that is

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-07-17 Thread Christian König
Am 16.07.19 um 18:40 schrieb Kuehling, Felix: On 2019-07-16 9:36 a.m., Christian König wrote: Am 02.07.19 um 21:35 schrieb Kuehling, Felix: This assumes that page tables are resident when a page fault is handled. Yeah, that is correct. I also haven't completely figured out how we can prevent

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-07-16 Thread Kuehling, Felix
On 2019-07-16 9:36 a.m., Christian König wrote: > Am 02.07.19 um 21:35 schrieb Kuehling, Felix: >> This assumes that page tables are resident when a page fault is handled. > > Yeah, that is correct. I also haven't completely figured out how we > can prevent the VM from being destroyed while

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-07-16 Thread Christian König
Am 02.07.19 um 21:35 schrieb Kuehling, Felix: This assumes that page tables are resident when a page fault is handled. Yeah, that is correct. I also haven't completely figured out how we can prevent the VM from being destroyed while handling the fault. I mean it's perfectly possible that

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-07-02 Thread Kuehling, Felix
This assumes that page tables are resident when a page fault is handled. I think it's possible that a page table gets evicted while a page fault is pending. Maybe not with graphics, but definitely with compute where waves can be preempted while waiting for a page fault. In that case the direct

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-06-28 Thread Christian König
Am 28.06.19 um 16:30 schrieb Chunming Zhou: 在 2019/6/28 20:18, Christian König 写道: This allows us to update page tables directly while in a page fault. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c |

Re: [PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-06-28 Thread Chunming Zhou
在 2019/6/28 20:18, Christian König 写道: > This allows us to update page tables directly while in a page fault. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5 > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c | 4 +++ >

[PATCH 1/5] drm/amdgpu: allow direct submission in the VM backends

2019-06-28 Thread Christian König
This allows us to update page tables directly while in a page fault. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 5 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c | 4 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c | 29 + 3 files