Re: [PATCH 1/6] drm/amdkfd: Update parameter type of pasid to uint16_t

2019-09-30 Thread Zhao, Yong
I will drop this one, because I found many other functions use 32 bits as well and it seems to be convenient. Regards, Yong On 2019-09-30 11:54 a.m., Kuehling, Felix wrote: > If you want to make this interface consistent, you should make the vmid > parameter uint8_t at the same time. That

Re: [PATCH 1/6] drm/amdkfd: Update parameter type of pasid to uint16_t

2019-09-30 Thread Kuehling, Felix
If you want to make this interface consistent, you should make the vmid parameter uint8_t at the same time. That said, you don't really save any resources, because 8-bit and 16-bit ints still consume 32-bits on the call stack. Regards,   Felix On 2019-09-27 11:41 p.m., Zhao, Yong wrote: >

[PATCH 1/6] drm/amdkfd: Update parameter type of pasid to uint16_t

2019-09-27 Thread Zhao, Yong
This is consistent with other code and registers in the code. Change-Id: I04dd12bdb465a43cfcd8936ed0f227a6546830e8 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c| 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 4 ++--