RE: [PATCH 10/12] drm/amdkfd: remove dead code in kq_initialize

2024-06-04 Thread Zhang, Jesse(Jie)
/amdkfd: remove dead code in kq_initialize On 2024-06-03 04:49, Jesse Zhang wrote: > The queue type can only be KFD_QUEUE_TYPE_DIQ or KFD_QUEUE_TYPE_HIQ, > and the default cannot be reached. I wonder, if you remove the default case, I guess you are relying on the compiler or a static chec

Re: [PATCH 10/12] drm/amdkfd: remove dead code in kq_initialize

2024-06-04 Thread Felix Kuehling
On 2024-06-03 04:49, Jesse Zhang wrote: The queue type can only be KFD_QUEUE_TYPE_DIQ or KFD_QUEUE_TYPE_HIQ, and the default cannot be reached. I wonder, if you remove the default case, I guess you are relying on the compiler or a static checker to ensure that we can only pass valid enum va

[PATCH 10/12] drm/amdkfd: remove dead code in kq_initialize

2024-06-03 Thread Jesse Zhang
The queue type can only be KFD_QUEUE_TYPE_DIQ or KFD_QUEUE_TYPE_HIQ, and the default cannot be reached. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c b/drivers/gpu/