Re: [PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation

2018-04-30 Thread Daniel Vetter
On Mon, Apr 30, 2018 at 8:26 PM, Christian König wrote: > Am 30.04.2018 um 17:38 schrieb Daniel Vetter: >> >> On Sun, Apr 29, 2018 at 09:08:31AM +0200, Christian König wrote: >>> >>> NAK, there is a subtitle but major difference: >>> - if (rdev->needs_reset) { -

Re: [PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation

2018-04-30 Thread Christian König
Am 30.04.2018 um 17:38 schrieb Daniel Vetter: On Sun, Apr 29, 2018 at 09:08:31AM +0200, Christian König wrote: NAK, there is a subtitle but major difference: - if (rdev->needs_reset) { - t = -EDEADLK; - break; - } Without

Re: [PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation

2018-04-30 Thread Daniel Vetter
On Sun, Apr 29, 2018 at 09:08:31AM +0200, Christian König wrote: > NAK, there is a subtitle but major difference: > > > - if (rdev->needs_reset) { > > - t = -EDEADLK; > > - break; > > - } > > Without that the whole radeon GPU reset code brea

Re: [PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation

2018-04-29 Thread Christian König
NAK, there is a subtitle but major difference: - if (rdev->needs_reset) { - t = -EDEADLK; - break; - } Without that the whole radeon GPU reset code breaks. Regards, Christian. Am 27.04.2018 um 08:17 schrieb Daniel Vette

[PATCH 13/17] drm/radeon: Remove custom dma_fence_ops->wait implementation

2018-04-26 Thread Daniel Vetter
It's a copy of dma_fence_default_wait, written slightly differently. Signed-off-by: Daniel Vetter Cc: Alex Deucher Cc: "Christian König" Cc: "David (ChunMing) Zhou" Cc: amd-gfx@lists.freedesktop.org --- drivers/gpu/drm/radeon/radeon_fence.c | 63 --- 1 file changed, 63