RE: [PATCH 2/2] drm/amd/amdgpu: force flush resubmit job

2021-02-25 Thread Liu, Monk
: Thursday, February 25, 2021 4:08 PM To: Chen, JingWen ; amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: Re: [PATCH 2/2] drm/amd/amdgpu: force flush resubmit job Good catch, but the approach for the fix is incorrect. The device reset count can only be incremented after taking the reset lock and

Re: [PATCH 2/2] drm/amd/amdgpu: force flush resubmit job

2021-02-25 Thread Christian König
H 2/2] drm/amd/amdgpu: force flush resubmit job Am 25.02.21 um 06:27 schrieb Jingwen Chen: [Why] when a job is scheduled during TDR(after device reset count increase and before drm_sched_stop), this job won't do vm_flush when resubmit itself after GPU reset done. This can lead to a page fa

RE: [PATCH 2/2] drm/amd/amdgpu: force flush resubmit job

2021-02-24 Thread Chen, JingWen
t: Re: [PATCH 2/2] drm/amd/amdgpu: force flush resubmit job Am 25.02.21 um 06:27 schrieb Jingwen Chen: > [Why] > when a job is scheduled during TDR(after device reset count increase > and before drm_sched_stop), this job won't do vm_flush when resubmit > itself after GPU reset do

Re: [PATCH 2/2] drm/amd/amdgpu: force flush resubmit job

2021-02-24 Thread Christian König
Am 25.02.21 um 06:27 schrieb Jingwen Chen: [Why] when a job is scheduled during TDR(after device reset count increase and before drm_sched_stop), this job won't do vm_flush when resubmit itself after GPU reset done. This can lead to a page fault. [How] Always do vm_flush for resubmit job. N

[PATCH 2/2] drm/amd/amdgpu: force flush resubmit job

2021-02-24 Thread Jingwen Chen
[Why] when a job is scheduled during TDR(after device reset count increase and before drm_sched_stop), this job won't do vm_flush when resubmit itself after GPU reset done. This can lead to a page fault. [How] Always do vm_flush for resubmit job. Signed-off-by: Jingwen Chen --- drivers/gpu/drm/