Re: [PATCH 2/2] drm/amdkfd: Put ASIC revision into HSA capability

2020-04-16 Thread Felix Kuehling
Thank you Joe. You can squash the two patches into one. KFD and AMDGPU are really one component, and separating changes into separate commits is not necessary. I'd also make amdgpu_amdkfd_get_asic_rev_id a static inline function in amdgpu_amdkfd.h, since it's just a one-liner. Other than that, th

[PATCH 2/2] drm/amdkfd: Put ASIC revision into HSA capability

2020-04-16 Thread Joseph Greathouse
In order to surface the ASIC revision to user level, we want to put it into the HSA topology. This can be because different ASIC revisions may require user-level software to do different things (e.g. patch code for things that are changed in later hardware revisions). The ASIC revision from the ha