Re: [PATCH 2/2] drm/ttm: completely rework ttm_bo_delayed_delete

2017-12-14 Thread Thomas Hellstrom
On 12/14/2017 02:17 PM, Christian König wrote: Am 14.12.2017 um 08:24 schrieb Thomas Hellstrom: On 12/13/2017 09:55 PM, Thomas Hellstrom wrote: Hi, Christian, While this has probably already been committed, and looks like a nice cleanup there are two things below I think needs fixing. On 11

Re: [PATCH 2/2] drm/ttm: completely rework ttm_bo_delayed_delete

2017-12-14 Thread Christian König
Am 14.12.2017 um 08:24 schrieb Thomas Hellstrom: On 12/13/2017 09:55 PM, Thomas Hellstrom wrote: Hi, Christian, While this has probably already been committed, and looks like a nice cleanup there are two things below I think needs fixing. On 11/15/2017 01:31 PM, Christian König wrote: There

Re: [PATCH 2/2] drm/ttm: completely rework ttm_bo_delayed_delete

2017-12-13 Thread Thomas Hellstrom
On 12/13/2017 09:55 PM, Thomas Hellstrom wrote: Hi, Christian, While this has probably already been committed, and looks like a nice cleanup there are two things below I think needs fixing. On 11/15/2017 01:31 PM, Christian König wrote: There is no guarantee that the next entry on the ddelet

Re: [PATCH 2/2] drm/ttm: completely rework ttm_bo_delayed_delete

2017-12-13 Thread Thomas Hellstrom
Hi, Christian, While this has probably already been committed, and looks like a nice cleanup there are two things below I think needs fixing. On 11/15/2017 01:31 PM, Christian König wrote: There is no guarantee that the next entry on the ddelete list stays on the list when we drop the locks.

Re: [PATCH 2/2] drm/ttm: completely rework ttm_bo_delayed_delete

2017-11-15 Thread Michel Dänzer
On 15/11/17 01:31 PM, Christian König wrote: > There is no guarantee that the next entry on the ddelete list stays on > the list when we drop the locks. > > Completely rework this mess by moving processed entries on a temporary > list. > > Signed-off-by: Christian König [...] > static void tt

[PATCH 2/2] drm/ttm: completely rework ttm_bo_delayed_delete

2017-11-15 Thread Christian König
There is no guarantee that the next entry on the ddelete list stays on the list when we drop the locks. Completely rework this mess by moving processed entries on a temporary list. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 77 ++--