Re: [PATCH 2/3] drm/amdgpu: allocate gart memory when it's required (v2)

2018-06-27 Thread Zhang, Jerry (Junwei)
On 06/28/2018 12:52 AM, Felix Kuehling wrote: On 2018-06-26 09:42 PM, Zhang, Jerry (Junwei) wrote: BTW, kfd2kgd_calls kfd2kgd looks duplicated in amdkfd_gfx_v7/8/9.c we may initialize it in a common place(at least for common members). If it has other purpose, please ignore that. Some of the

Re: [PATCH 2/3] drm/amdgpu: allocate gart memory when it's required (v2)

2018-06-27 Thread Felix Kuehling
On 2018-06-26 09:42 PM, Zhang, Jerry (Junwei) wrote: > > BTW, kfd2kgd_calls kfd2kgd looks duplicated in amdkfd_gfx_v7/8/9.c > we may initialize it in a common place(at least for common members). > If it has other purpose, please ignore that. Some of the function pointers in kfd2kgd_calls are

Re: [PATCH 2/3] drm/amdgpu: allocate gart memory when it's required (v2)

2018-06-26 Thread Zhang, Jerry (Junwei)
On 06/26/2018 11:53 PM, Felix Kuehling wrote: Comments inline [FK] On 2018-06-26 04:35 AM, Junwei Zhang wrote: Instead of calling gart memory on every bo pin, allocates it on demand v2: fix error handling Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c|

Re: [PATCH 2/3] drm/amdgpu: allocate gart memory when it's required (v2)

2018-06-26 Thread Felix Kuehling
Comments inline [FK] On 2018-06-26 04:35 AM, Junwei Zhang wrote: > Instead of calling gart memory on every bo pin, > allocates it on demand > > v2: fix error handling > > Signed-off-by: Junwei Zhang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 6 ++ >

[PATCH 2/3] drm/amdgpu: allocate gart memory when it's required (v2)

2018-06-26 Thread Junwei Zhang
Instead of calling gart memory on every bo pin, allocates it on demand v2: fix error handling Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 6 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 ++