add two new powerplay enums (limit_level, type)
add enums to smu_get_power_limit signature
remove input bitfield stuffing of output variable limit
update calls to smu_get_power_limit
* Test
AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1`
AMDGPU_HWMON=`ls -la /sys/class/hw
: Lazar, Lijo ; amd-gfx@lists.freedesktop.org
Cc: Quan, Evan
Subject: Re: [PATCH 2/6] amdgpu/pm: clean up smu_get_power_limit function
signature
[Public]
I think both of those candidates have drawbacks
** option #1 has a clash with the limit_level
eg.
enum pp_power_limit_level limit
PP_PWR_LIMIT_1,
PP_PWR_LIMIT_2,
PP_PWR_LIMIT_3,
};
Thanks,
Lijo
From: Powell, Darren
Sent: Wednesday, June 2, 2021 9:25 AM
To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/6] amdgpu/pm: clean up smu_get_power_limit function
signature
[Public]
I
MIT_3,
};
Thanks,
Lijo
From: Powell, Darren
Sent: Wednesday, June 2, 2021 9:25 AM
To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/6] amdgpu/pm: clean up smu_get_power_limit function
signature
[Public]
I'm not sure exactly what you are looking for. The enums sample_
2021 12:56 AM
To: Powell, Darren ; amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH 2/6] amdgpu/pm: clean up smu_get_power_limit function
signature
[Public]
May be just call it power_limit or power_cap similar to hwmon. The various
limits correspond to hwmon power[1-*]_cap and levels corre
: Re: [PATCH 2/6] amdgpu/pm: clean up smu_get_power_limit function
signature
[Public]
>< > The limits are not limited to sample window. There are limits like APU
>only limit, platform limit and totally obscure ones like PPT0/PPT1 etc.
>It's better that the new enum takes care
sktop.org
Subject: RE: [PATCH 2/6] amdgpu/pm: clean up smu_get_power_limit function
signature
[Public]
-Original Message-
From: Powell, Darren
Sent: Saturday, May 29, 2021 4:36 AM
To: amd-gfx@lists.freedesktop.org
Cc: Powell, Darren
Subject: [PATCH 2/6] amdgpu/pm: clean up smu_get_power_l
[Public]
-Original Message-
From: Powell, Darren
Sent: Saturday, May 29, 2021 4:36 AM
To: amd-gfx@lists.freedesktop.org
Cc: Powell, Darren
Subject: [PATCH 2/6] amdgpu/pm: clean up smu_get_power_limit function signature
add two new powerplay enums (limit_level, sample_window) add
add two new powerplay enums (limit_level, sample_window)
add enums to smu_get_power_limit signature
remove input bitfield stuffing of output variable limit
update calls to smu_get_power_limit
* Test
AMDGPU_PCI_ADDR=`lspci -nn | grep "VGA\|Display" | cut -d " " -f 1`
AMDGPU_HWMON=`ls -la /sys
