Re: [PATCH 3/3] drm/amdgpu: replace get_user_pages with HMM address mirror helpers v4

2018-12-14 Thread Yang, Philip
Hi Felix, Thanks, I will submit another patch to fix those KFD part issues. Philip On 2018-12-14 2:54 p.m., Kuehling, Felix wrote: > Looks good for the KFD part. One nit-pick inline. And two more > suggestions about amdgpu_ttm.c to make our handling of > get_user_pages_done more robust. > >

Re: [PATCH 3/3] drm/amdgpu: replace get_user_pages with HMM address mirror helpers v4

2018-12-14 Thread Kuehling, Felix
Looks good for the KFD part. One nit-pick inline. And two more suggestions about amdgpu_ttm.c to make our handling of get_user_pages_done more robust. Christian, would you review the CS and GEM parts? And maybe take a look you see nothing wrong with the amdgpu_ttm changes either. On 2018-12-13

[PATCH 3/3] drm/amdgpu: replace get_user_pages with HMM address mirror helpers v4

2018-12-13 Thread Yang, Philip
Use HMM helper function hmm_vma_fault() to get physical pages backing userptr and start CPU page table update track of those pages. Then use hmm_vma_range_done() to check if those pages are updated before amdgpu_cs_submit for gfx or before user queues are resumed for kfd. If userptr pages are