Re: [PATCH 3/3] drm/amdkfd: Remove the control stack workaround for GFX10

2019-09-26 Thread Zhao, Yong
Subject: Re: [PATCH 3/3] drm/amdkfd: Remove the control stack workaround for GFX10 Yes. I confirmed with CP guys and they said the behavior on GFX10 is the same as GFX8 now. I remember that the workaround on GFX9 was to help with a HW bug, but not too sure. Regards, Yong On 2019-09-25 2:25 p.m

Re: [PATCH 3/3] drm/amdkfd: Remove the control stack workaround for GFX10

2019-09-25 Thread Zhao, Yong
Yes. I confirmed with CP guys and they said the behavior on GFX10 is the same as GFX8 now. I remember that the workaround on GFX9 was to help with a HW bug, but not too sure. Regards, Yong On 2019-09-25 2:25 p.m., Kuehling, Felix wrote: > On 2019-09-25 2:15 p.m., Zhao, Yong wrote: >> The GFX10

Re: [PATCH 3/3] drm/amdkfd: Remove the control stack workaround for GFX10

2019-09-25 Thread Kuehling, Felix
On 2019-09-25 2:15 p.m., Zhao, Yong wrote: > The GFX10 does not have this hardware bug any more, so remove it. I wouldn't call this a bug and a workaround. More like a change in the HW or FW behaviour and a corresponding driver change. I.e. in GFXv8 the control stack was in the user mode CWSR al

[PATCH 3/3] drm/amdkfd: Remove the control stack workaround for GFX10

2019-09-25 Thread Zhao, Yong
The GFX10 does not have this hardware bug any more, so remove it. Change-Id: I446c9685549a09ac8846a42ee22d86cfb93fd98c Signed-off-by: Yong Zhao --- .../gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c | 37 ++- 1 file changed, 4 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/d