Re: [PATCH 3/5] drm/amdgpu/smu: add metrics table lock for navi

2019-12-17 Thread Deucher, Alexander
] drm/amdgpu/smu: add metrics table lock for navi Hi Alex, Isn't this patch missing something like this: pr_info("Failed to export SMU metrics table!\n"); + mutex_unlock(&smu->metrics_lock); return ret; to release the lock in case of error? Regards, Pierre-Eric

Re: [PATCH 3/5] drm/amdgpu/smu: add metrics table lock for navi

2019-12-17 Thread Pierre-Eric Pelloux-Prayer
Hi Alex, Isn't this patch missing something like this: pr_info("Failed to export SMU metrics table!\n"); + mutex_unlock(&smu->metrics_lock); return ret; to release the lock in case of error? Regards, Pierre-Eric On 17/12/2019 15:55, Alex Deucher wrote: > To protect access to the me

[PATCH 3/5] drm/amdgpu/smu: add metrics table lock for navi

2019-12-17 Thread Alex Deucher
To protect access to the metrics table. Bug: https://gitlab.freedesktop.org/drm/amd/issues/900 Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerp